Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when language is changed [scripting disabled] #2544

Closed
alex-w opened this issue Aug 2, 2022 · 9 comments
Closed

Crash when language is changed [scripting disabled] #2544

alex-w opened this issue Aug 2, 2022 · 9 comments
Assignees
@gzotti
Labels
bug Something likely wrong in the code importance: critical Real showstopper, program fails here qt Issues, related to Qt framework
Projects
GUI
Milestone
1.0

Comments

@alex-w
Copy link
Member

alex-w commented Aug 2, 2022 •
edited
Loading

Expected Behaviour

Changed language of GUI after selection of language in dropdown list of languages

Actual Behaviour

Crash after selection of language in dropdown list of languages

Steps to reproduce

  1. Run Stellarium.
  2. Open Configuration dialog (F2).
  3. Select the language of main program

System

  • Stellarium version: 1.22.2-3d47d9a (universal)
  • Operating system: macOS 12.5
  • Graphics Card: irrelevant
  • Screen type (if applicable): irrelevant

Logfile

If possible, attach the logfile log.txt from your user data directory. Look into the Guide for its location.
@alex-w alex-w added bug Something likely wrong in the code importance: critical Real showstopper, program fails here labels Aug 2, 2022
@alex-w alex-w added this to the 0.22.3 milestone Aug 2, 2022
@alex-w alex-w added this to Needs triage in GUI via automation Aug 2, 2022
@alex-w alex-w added the qt Issues, related to Qt framework label Aug 2, 2022
@alex-w alex-w moved this from Needs triage to To do in GUI Aug 2, 2022
@alex-w
Copy link
Member Author

alex-w commented Aug 3, 2022

@gzotti @worachate001 please check the crash on Windows and linux also...

@gzotti
Copy link
Member

gzotti commented Aug 3, 2022

Changing from startup in German. Poof!

But I have a hint from log.txt:

Application language is "et"
Couldn't load translations for language "et" in section "stellarium-scripts"
Empty translation file for language "et" in section "stellarium-scripts"
Scripts language is "et"

This Qt6 build is necessarily still without scripting!

However, changing sky culture language also crashes:

Sky language is "et"
Planetary features language is "et"

Also changing to English (en) crashes. :-(

@alex-w
Copy link
Member Author

alex-w commented Aug 3, 2022

These hints you may see with Qt5 too when translation is not exist, but without crashes. I guess this is unrelated to the problem.

@alex-w alex-w added the state: confirmed A developer can reproduce the issue label Aug 4, 2022
@github-actions
Copy link

github-actions bot commented Aug 4, 2022

Hello @alex-w! OK, developers can reproduce the issue. Thanks for the report!

@gzotti
Copy link
Member

gzotti commented Aug 4, 2022

I thought this was a Qt6 issue. Now a Qt5.15 debug build also crashed!

@gzotti gzotti self-assigned this Aug 4, 2022
@gzotti gzotti changed the title [qt6] Crash when language is changed Crash when language is changed [scripting disabled] Aug 4, 2022
@gzotti
Copy link
Member

gzotti commented Aug 4, 2022

I found what happens:
With scripting disabled, the last page in the config dialog is removed.
When changing language, the ui->retranslateUi() call wants to translate everything. But it does not find the last tab. Nullptr->crash.
I can hopefully find a better way to hide, not delete, the script tab. Or keep an empty script dialog.

This should be a minimal nuisance when scripting is reactivated again also in Qt6.

@gzotti gzotti closed this as completed in 63f6bd9 Aug 4, 2022
GUI automation moved this from To do to Done Aug 4, 2022
@gzotti gzotti mentioned this issue Aug 7, 2022
Closed
@alex-w alex-w added the state: fixed The bug has been fixed label Sep 4, 2022
@github-actions
Copy link

github-actions bot commented Sep 4, 2022

Hello @alex-w! Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w added state: published The fix has been published for testing in weekly binary package and removed state: fixed The bug has been fixed labels Sep 10, 2022
@github-actions
Copy link

Hello @alex-w!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: confirmed A developer can reproduce the issue label Sep 17, 2022
@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Oct 1, 2022
@github-actions
Copy link

github-actions bot commented Oct 1, 2022

Hello @alex-w!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gzotti gzotti

Labels
bug Something likely wrong in the code importance: critical Real showstopper, program fails here qt Issues, related to Qt framework
Projects
GUI
  
Done
Milestone
1.0
Development

No branches or pull requests
2 participants
@alex-w @gzotti