Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hawaiian Starlines - Missing star names #2808

Closed
papakilohoku opened this issue Nov 1, 2022 · 15 comments
Closed

Hawaiian Starlines - Missing star names #2808

papakilohoku opened this issue Nov 1, 2022 · 15 comments
Assignees
Labels
bug Something likely wrong in the code data Missing/bad/outdated data, but no code error state: confirmed A developer can reproduce the issue
Milestone

Comments

@papakilohoku
Copy link

Expected Behaviour

There are missing star names and labels for some of the stars and celestial bodies in a number of "starlines." They were included previous versions It appears that they were deleted in the latest upgrade into 1.0 and subsequent 1.1.

Actual Behaviour

Describe or maybe attach a screenshot?
https://drive.google.com/file/d/1CfPEm0PwwqU_x1V-lLyVxz7TGqq9IkND/view?usp=sharing

Steps to reproduce

The stars that were loaded in previous versions are missing. If there was a way to update these items, please advise and we will be working on updating them on our side to submit to you. Please advise when possible.

System

  • Stellarium version: <1.1>
  • Operating system: <MacOS 12.6>
  • Graphics Card: <Manufacturer (likely Intel, NVidia, AMD?), Model (HD, Geforce, Radeon..., with model number), driver version?>
  • Screen type (if applicable): Resolution, HighDPI, scaling

Logfile

If possible, attach the logfile log.txt from your user data directory. Look into the Guide for its location.
Kallupe_o_kawelo

@gzotti
Copy link
Member

gzotti commented Nov 2, 2022

Can you please indicate which earlier version had included names for these stars? The last change seems to have happened more than 1 year ago.

@alex-w alex-w added this to Needs triage in Sky Cultures via automation Nov 2, 2022
@alex-w alex-w added the data Missing/bad/outdated data, but no code error label Nov 2, 2022
@papakilohoku
Copy link
Author

I am unsure. I believe that they were there in the version that was utilized around this time last year (I use it as a teaching tool in my course). I did not notice that it was missing until this current version of 1.0 and 1.1.

Is there a way that I could load older versions to check?

@alex-w
Copy link
Member

alex-w commented Nov 3, 2022

@papakilohoku
Copy link
Author

papakilohoku commented Nov 3, 2022

Copy that. I think that the last change made the stars disappear as it is in the same local area as the one change mentioned in the history.
Ka_lupe_o_kawelo_labeled

@gzotti
Copy link
Member

gzotti commented Nov 3, 2022

Copy that. I think that the last change made the stars disappear as it is in the same local area as the one change mentioned in the history.

The only change to the star name file done after first inclusion was #1931. Here, a false duplicate was removed.
Is it possible you have a private skyculture of the same name installed which "overwrites" the built-in?

@papakilohoku
Copy link
Author

I do not think so as the other students in my class do not see the other names either. Do you see those stars and names on your end?

@gzotti
Copy link
Member

gzotti commented Nov 3, 2022

No, we have never seen them. This is what I am trying to say. We never have received names for those stars in the hawaiian_starlines SC.

@papakilohoku
Copy link
Author

Interesting, as the screen shots that we were using were from a previous version of stellarium. Iʻll try to get up to speed and make those corrections

@papakilohoku
Copy link
Author

It also is shown on the iphone app version when you (or whoever made the apple app version) copied the information. We will work with that.

Is there a quick primer of how to make those additions available on the github? Would you be able to point me in to the proper direction? Thank you.

@alex-w
Copy link
Member

alex-w commented Nov 3, 2022

@papakilohoku could you share config.ini file?

@alex-w alex-w self-assigned this Nov 3, 2022
@alex-w alex-w added this to the 1.2 milestone Nov 3, 2022
@alex-w alex-w moved this from Needs triage to To do in Sky Cultures Nov 3, 2022
@papakilohoku
Copy link
Author

The original submission was from 2017. Not sure if we still have the file. We will look for it as best as we can. Are there any other ways to access the config.ini file from previous versions?

@gzotti
Copy link
Member

gzotti commented Nov 4, 2022

what has config.ini to do with that?

@alex-w alex-w added bug Something likely wrong in the code state: confirmed A developer can reproduce the issue labels Nov 9, 2022
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

Hello @papakilohoku!

OK, developers can reproduce the issue. Thanks for the report!

@alex-w alex-w closed this as completed in 31fd90c Nov 9, 2022
Sky Cultures automation moved this from To do to Done Nov 9, 2022
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Nov 20, 2022
@github-actions
Copy link

Hello @papakilohoku!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Dec 25, 2022
@github-actions
Copy link

Hello @papakilohoku!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something likely wrong in the code data Missing/bad/outdated data, but no code error state: confirmed A developer can reproduce the issue
Projects
Sky Cultures
  
Done
Development

No branches or pull requests

3 participants