Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default list of comets #3261

Closed
alex-w opened this issue Jun 3, 2023 · 10 comments · Fixed by #3276
Closed

Default list of comets #3261

alex-w opened this issue Jun 3, 2023 · 10 comments · Fixed by #3276
Assignees
Labels
data Missing/bad/outdated data, but no code error
Milestone

Comments

@alex-w
Copy link
Member

alex-w commented Jun 3, 2023

When I worked for partially fix an issue #3224 (see PR #3230) I got an important idea - we should revised the default list of comets:

  • The number of comets should be reduced (probably 10-15 comets at well - most bright and/or most famous and maybe expected be bright in near future)
  • Historical data should contains correct designation and correct orbital elements (for observable epoch!) - to avoid mix with modern data the name should contains an asterix.
  • The modern comets probably should be revised per every release
@alex-w alex-w added the data Missing/bad/outdated data, but no code error label Jun 3, 2023
@alex-w alex-w added this to Needs triage in Solar System via automation Jun 3, 2023
@alex-w alex-w added this to the 23.2 milestone Jun 3, 2023
@alex-w alex-w moved this from Needs triage to To do in Solar System Jun 3, 2023
@gzotti
Copy link
Member

gzotti commented Jun 3, 2023

On the historical (1000 comets) file: These data have a known source, so orbital elements at their epoch should be OK. I am not sure, as this was years ago, I may not have recorded the epoch, as our elements did not have this entry at that time. It is usually close enough to perihelion to assume perihelion date as epoch. We have seen earlier that it is not useful to update elements of historical comets with elements for the current epoch!

Please do not add asterix to the names. Yes, the name should be correct with all possible styles. The file ends around year 2000, so this would just add a a star to all comets before 2000.

+1 for revising the default list. If interesting comets have been announced, we should consider fetching data for current/upcoming comets. Comets which were dimmer than mag10 or so can probably be removed a year after perihel. "Cleanup" functions could also be added to the SSeditor, if users never look back, all past elements could be removed.

@alex-w alex-w self-assigned this Jun 5, 2023
@alex-w
Copy link
Member Author

alex-w commented Jun 16, 2023

See also #1241 and #561

@alex-w
Copy link
Member Author

alex-w commented Jun 19, 2023

Probably we should add few very bright comets (naked eye visible - a "great comets") and some historically important comets, like comet Halley. Is it ok?

Second part - comets, which expected to be bright in near future (0.5-1 year) - but what is limit of brightness?

@gzotti
Copy link
Member

gzotti commented Jun 19, 2023

You could copy (not move!) entries for Halley 1910 (if still useful?) & 1986, Hyakutake, Hale-Bopp from the 1000comets file. Whatever was important (brighter than mag6?) after 2000 (McNaught 2006, one in 2013, 2021, Holmes ~2017?) may be nice. Comet experts will have their own preferences and add more. Always use epoch close to perihel.

If we add elements for future comets, we must say somewhere that they are tentative, subject to changes, and any serious magnitude/visibility prognosis many months in advance is next to impossible, so users must seek additional info and update elements when the comet approaches and they go serious about observing. Do you know a website which could be configured for access via OnlineQuery?

@alex-w
Copy link
Member Author

alex-w commented Jun 19, 2023

Candidates: Brightest comets seen since 1935

@gzotti
Copy link
Member

gzotti commented Jun 19, 2023

Interesting list. However, for most users I think we need not go back so far, and only include real eyecatchers, e.g. mag3 and brighter. The SSO list should not be longer than necessary unless users decide on it. Maybe add another loadable list brightest_comets_since_1935.ini.

@alex-w
Copy link
Member Author

alex-w commented Jun 20, 2023

Interesting list. However, for most users I think we need not go back so far, and only include real eyecatchers, e.g. mag3 and brighter. The SSO list should not be longer than necessary unless users decide on it. Maybe add another loadable list brightest_comets_since_1935.ini.

Probably adding data from lists THE BRIGHT-COMET CHRONICLES and Brightest comets seen since 1935 into one list bright_comets.ini may be good another loadable list.

@alex-w
Copy link
Member Author

alex-w commented Jun 20, 2023

Other good source to fix designations in our data: COMET NAMES AND DESIGNATIONS

Solar System automation moved this from To do to Done Jun 20, 2023
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Jun 25, 2023
@github-actions
Copy link

Hello @alex-w!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Jul 2, 2023
@github-actions
Copy link

github-actions bot commented Jul 2, 2023

Hello @alex-w!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data Missing/bad/outdated data, but no code error
Projects
Solar System
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants