Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to cache RTS to avoid costly recomputation #3275

Closed
gzotti opened this issue Jun 19, 2023 · 4 comments
Closed

Try to cache RTS to avoid costly recomputation #3275

gzotti opened this issue Jun 19, 2023 · 4 comments
Assignees
@worachate001
Labels
enhancement Improve existing functionality
Projects
Solar System
Milestone
23.3

Comments

@gzotti
Copy link
Member

gzotti commented Jun 19, 2023

We should cache our RTS computation to avoid recomputation at every frame.

Expected Behaviour

FPS drops somewhat when InfoText is shown, but decent system remains at interactive framerates

Actual Behaviour

As mentioned in #3265, RTS may be very expensive and bogs down even a 10th-gen Core-i CPU.

Steps to reproduce

Select object (esp. Moon), observe framerate drop when InfoText is visible. Note esp. effect of RTS display.

System

  • Stellarium version: 23.1
  • Operating system: Windows (but likely any)
  • Graphics Card: irrelevant

Logfile

If possible, attach the logfile log.txt from your user data directory. Look into the Guide for its location.
@gzotti gzotti added this to the 23.3 milestone Jun 19, 2023
@gzotti gzotti added this to Needs triage in Solar System via automation Jun 19, 2023
@gzotti gzotti added the enhancement Improve existing functionality label Jun 19, 2023
@github-actions
Copy link

Hello @gzotti!

Thank you for suggesting this enhancement.

@alex-w alex-w moved this from Needs triage to To do in Solar System Jun 19, 2023
@gzotti gzotti modified the milestones: 23.3, 23.4 Sep 4, 2023
@worachate001 worachate001 self-assigned this Sep 10, 2023
@worachate001 worachate001 modified the milestones: 23.4, 23.3 Sep 10, 2023
Solar System automation moved this from To do to Done Sep 10, 2023
@gzotti
Copy link
Member Author

gzotti commented Sep 10, 2023

Thanks!

@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Sep 11, 2023
@github-actions
Copy link

Hello @gzotti!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Sep 26, 2023
@github-actions
Copy link

Hello @gzotti!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@worachate001 worachate001

Labels
enhancement Improve existing functionality
Projects
Solar System
  
Done
Milestone
23.3
Development

No branches or pull requests
3 participants
@alex-w @gzotti @worachate001