Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkboxes to hide specific categories of Solar System objects #3317

Closed
Cynosurae opened this issue Jul 8, 2023 · 7 comments
Closed

Checkboxes to hide specific categories of Solar System objects #3317

Cynosurae opened this issue Jul 8, 2023 · 7 comments
Assignees
Labels
enhancement Improve existing functionality
Milestone

Comments

@Cynosurae
Copy link

Is your feature request related to a problem? Please describe.
There's been a few cases where I'd like to capture a skybox which includes the full Moon, but does not include the bright planets, such as Jupiter. Using the existing checkbox to toggle off Solar System objects also toggles off the Moon.

Describe the solution you'd like
In the Sky and Viewing options window, under SSO, there is currently a checkbox labeled "Solar System Objects", which toggles showing the Moon and planets. I would like to suggest that we add secondary checkboxes under the SSO checkbox. These secondary checkboxes would be labeled Show Sun, Show Moon, Show Planets, and Show Small Bodies. Small Bodies would cover everything that is not the Sun, Moon, or a major planet; this includes dwarf planets, planetary satellites, asteroids, comets, TNOs, etc.

The flow would be something like this:
If SSO is toggled on, then the Sun/Moon/Planets/Small Bodies secondary checkboxes are enabled and can be interacted with. Default behavior is that all of the secondary checkboxes are On, resulting in behavior that is the same as current Stellarium. Objects that are toggled on will still follow the Limit Magnitude constraint.

If SSO is toggled on, but only one of the secondary checkboxes (for example the Moon) is toggled on, then only the Moon is visible. The same logic would apply to toggling the other checkboxes or multiple checkboxes at once.

If SSO is toggled off, the secondary checkboxes are grayed-out and cannot be interacted with. Toggling SSO off hides all Solar System objects (as it is in current Stellarium), regardless of the setting of the secondary checkboxes.

Describe alternatives you've considered
I have also tried using the "Limit magnitude" feature, so that I can hide everything but the Moon. However, the limiting magnitude cannot be set lower than 0.00, meaning that I cannot hide bright planets like Jupiter or Venus. Allowing the limiting magnitude to be set to negative numbers would resolve my issue, so that I can hide everything but the Moon.

The checkbox solution would probably require more work, but it would be more generally applicable to other use cases.

Additional context
No other context.

@github-actions
Copy link

github-actions bot commented Jul 8, 2023

Thanks for adding your first issue to Stellarium. If you have questions, please do not hesitate to contact us.

@gzotti
Copy link
Member

gzotti commented Jul 8, 2023

I think we should not clutter the GUI with yet more checkboxes. Raising the limiting magnitude to -5 to exclude everything including Venus sounds acceptable for me. (If a mag -8 comet comes, it will still be visible ;-)

@gzotti gzotti added the enhancement Improve existing functionality label Jul 8, 2023
@github-actions
Copy link

github-actions bot commented Jul 8, 2023

Hello @Cynosurae!

Thank you for suggesting this enhancement.

@gzotti gzotti added this to the 23.3 milestone Jul 8, 2023
@gzotti gzotti added this to Needs triage in Solar System via automation Jul 8, 2023
@alex-w
Copy link
Member

alex-w commented Jul 24, 2023

@Cynosurae please describe use cases for new behavior…

@alex-w alex-w added this to Needs triage in Didactic via automation Jul 24, 2023
@alex-w alex-w modified the milestones: 23.3, 23.4 Sep 11, 2023
@gzotti gzotti self-assigned this Dec 3, 2023
@gzotti gzotti closed this as completed in e07d03b Dec 3, 2023
Solar System automation moved this from Needs triage to Done Dec 3, 2023
Didactic automation moved this from Needs triage to Done Dec 3, 2023
@gzotti
Copy link
Member

gzotti commented Dec 3, 2023

I just raised the mag limit now. IMHO this is enough for this use case.

@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Dec 4, 2023
Copy link

github-actions bot commented Dec 4, 2023

Hello @Cynosurae!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Dec 23, 2023
Copy link

Hello @Cynosurae!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality
Projects
Didactic
  
Done
Solar System
  
Done
Development

No branches or pull requests

3 participants