Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calendars plugin: Crash when New Hindu Lunar Calendar enabled #3442

Closed
worachate001 opened this issue Oct 3, 2023 · 5 comments
Closed

Calendars plugin: Crash when New Hindu Lunar Calendar enabled #3442

worachate001 opened this issue Oct 3, 2023 · 5 comments
Assignees
@gzotti
Labels
bug Something likely wrong in the code importance: critical Real showstopper, program fails here
Projects
Plugin
Milestone
23.4

Comments

@worachate001
Copy link
Member

Expected Behaviour

No crash.

Actual Behaviour

Crash and this error comes up:
ASSERT: "phaseA<=phaseMid" in file /home/worachate/stellarium/plugins/Calendars/src/NewHinduCalendar.cpp, line 651

Steps to reproduce

  1. Calendars plugin enabled
  2. New Hindu Lunar Calendar enabled
  3. Click Calendar button [Alt+K]

System

  • Stellarium version: 23.3+ (latest master)
  • Operating system: Fedora Linux 38 (Workstation Edition)

Logfile

If possible, attach the logfile log.txt from your user data directory. Look into the Guide for its location.
@alex-w alex-w added bug Something likely wrong in the code importance: critical Real showstopper, program fails here labels Oct 3, 2023
@alex-w alex-w added this to Needs triage in Plugin via automation Oct 3, 2023
@alex-w alex-w added this to the 23.4 milestone Oct 3, 2023
@gzotti
Copy link
Member

gzotti commented Oct 3, 2023

Given that all tests run OK, please give a calendar date, time and location.

@worachate001
Copy link
Member Author

The location is Bangkok (UTC+7). Date and Time is present day (2023-10-05 22:00:00, for example). I tried changing to other years, dates, times, locations, and got the same result in this debug mode.

@alex-w
Copy link
Member

alex-w commented Oct 5, 2023

I fear it can be reproduced in debug mode only

@gzotti gzotti closed this as completed in eb815f0 Oct 15, 2023
Plugin automation moved this from Needs triage to Done Oct 15, 2023
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Oct 23, 2023
@github-actions
Copy link

Hello @worachate001!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Dec 23, 2023
@github-actions GitHub Actions
Copy link

Hello @worachate001!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gzotti gzotti

Labels
bug Something likely wrong in the code importance: critical Real showstopper, program fails here
Projects
Plugin
  
Done
Milestone
23.4
Development

No branches or pull requests
3 participants
@alex-w @gzotti @worachate001