Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rise/Transit/Set info gets wrong after switching location if the object was selected #3602

Closed
10110111 opened this issue Jan 21, 2024 · 8 comments
Closed

Rise/Transit/Set info gets wrong after switching location if the object was selected #3602

10110111 opened this issue Jan 21, 2024 · 8 comments
Assignees
@worachate001
Labels
bug Something likely wrong in the code
Projects
Solar System InfoBox
Milestone
24.1

Comments

@10110111
Copy link
Contributor

10110111 commented Jan 21, 2024 •
edited

Steps to reproduce

  1. Disable "Use custom time zone" in Location dialog so that the TZ switches automatically
  2. Switch location to Novoaltaysk
  3. Select the Sun
  4. Check that rise/transit/set times are sensible (sunrise about 9:26, sunset about 17:44 on January 21)
  5. Keeping the Sun selected, switch location to Saint Petersburg
  6. Look at rise/transit/set of the Sun

Expected Behaviour

Transit is somewhere around 13:00.

Actual Behaviour

  • Times are shifted so that transit is given around the actual rise time, and set is reported near the actual noon.
  • Clearing the selection and selecting the Sun doesn't help.
  • Selecting another object, e.g. LMC, and then back again the Sun fixes the times reported.

Screenshot_2024-01-20_20-30-25

System

  • Stellarium version: v23.4-48-gd05e0e82dc
  • Operating system: Ubuntu 20.04
  • Graphics Card: Intel UHD Graphics 620

Logfile

log.txt
@alex-w alex-w self-assigned this Jan 21, 2024
@alex-w alex-w added the bug Something likely wrong in the code label Jan 21, 2024
@alex-w alex-w added this to the 24.1 milestone Jan 21, 2024
@alex-w alex-w added this to Needs triage in Astronomical calculations (AstroCalc) via automation Jan 21, 2024
@alex-w alex-w added enhancement Improve existing functionality and removed bug Something likely wrong in the code labels Jan 21, 2024
@github-actions GitHub Actions
Copy link

Hello @10110111!

Thank you for suggesting this enhancement.

@alex-w alex-w closed this as completed in cbb18be Jan 21, 2024
Astronomical calculations (AstroCalc) automation moved this from Needs triage to Done Jan 21, 2024
@10110111
Copy link
Contributor Author

The problem still reproduces with the original reproduction steps.

@10110111 10110111 reopened this Jan 22, 2024
Astronomical calculations (AstroCalc) automation moved this from Done to In progress Jan 22, 2024
@alex-w
Copy link
Member

alex-w commented Jan 23, 2024

The problem still reproduces with the original reproduction steps.

How it possible? I can't reproduce it

@10110111
Copy link
Contributor Author

Did you reproduce it before your change?

@alex-w
Copy link
Member

alex-w commented Jan 23, 2024

Did you reproduce it before your change?

Yes, of course

@alex-w
Copy link
Member

alex-w commented Jan 23, 2024

Stop! I’m an idiot, because I added the fix for AstroCalc tool, but you’re saying about infobox

@alex-w alex-w removed this from In progress in Astronomical calculations (AstroCalc) Jan 23, 2024
@alex-w alex-w added this to Needs triage in Solar System via automation Jan 23, 2024
@alex-w alex-w added this to Needs triage in InfoBox via automation Jan 23, 2024
@alex-w alex-w removed their assignment Jan 23, 2024
@alex-w alex-w added bug Something likely wrong in the code and removed enhancement Improve existing functionality labels Jan 23, 2024
@worachate001 worachate001 self-assigned this Jan 27, 2024
@worachate001 worachate001 moved this from Needs triage to In progress in InfoBox Jan 27, 2024
@worachate001 worachate001 moved this from Needs triage to In progress in Solar System Jan 27, 2024
Solar System automation moved this from In progress to Done Jan 28, 2024
InfoBox automation moved this from In progress to Done Jan 28, 2024
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Feb 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2024

Hello @10110111!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Mar 26, 2024
@github-actions GitHub Actions
Copy link

Hello @10110111!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@worachate001 worachate001

Labels
bug Something likely wrong in the code
Projects
InfoBox
  
Done
Solar System
  
Done
Milestone
24.1
Development

No branches or pull requests
3 participants
@alex-w @10110111 @worachate001