Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meteor shower issue #3616

Closed
TheSuggestionGuy opened this issue Jan 31, 2024 · 4 comments
Closed

Meteor shower issue #3616

TheSuggestionGuy opened this issue Jan 31, 2024 · 4 comments
Assignees
Labels
bug Something likely wrong in the code
Projects
Milestone

Comments

@TheSuggestionGuy
Copy link

So, go to, somewhere in Africa, like Nouakchott (it's in UTC time so you can understand, this applies to every location) and remove the ground, and click on the Quadrantids, then go to the second before new year's 2025, then, you can see the meteor showers color is orange, and it has info saying: ZHRmax, Current ZHR, and Local Hourly Rate. Then on midnight of 2025, the meteor shower color becomes white, then Current ZHR, and Local Hourly Rate disappears, and ZHRmax becomes ZHRmax variable, and it's instead in a range. and it applies to all meteor showers, in all locations. so please fix this.

Originally posted by @TheSuggestionGuy in #3615

@TheSuggestionGuy TheSuggestionGuy changed the title So, go to, somewhere in Africa, like Nouakchott (it's in UTC time so you can understand, this applies to every location) and remove the ground, and click on the Quadrantids, then go to the second before new year's 2025, then, you can see the meteor showers color is orange, and it has info saying: ZHRmax, Current ZHR, and Local Hourly Rate. Then on midnight of 2025, the meteor shower color becomes white, then Current ZHR, and Local Hourly Rate disappears, and ZHRmax becomes ZHRmax variable, and it's instead in a range. and it applies to all meteor showers, in all locations. so please fix this. Meteor shower issue Jan 31, 2024
Copy link

Thanks for adding your first issue to Stellarium. If you have questions, please do not hesitate to contact us.

@alex-w alex-w added this to Needs triage in Plugin via automation Jan 31, 2024
@worachate001
Copy link
Member

Recently, we just made a modification to this plugin that changes behavior (see #3549). However, there is a remaining bug explained in this issue. It happens for meteor showers that start in December and end in January/February. In this example, near the end of 2024, the shower shouldn't use 2024 data and must switch to 'generic' one (because we don't have 2025 prediction yet for Quadrantids).

I will take a closer look to find a way to fix.

@worachate001 worachate001 moved this from Needs triage to To do in Plugin Jan 31, 2024
@worachate001 worachate001 added this to the 24.1 milestone Jan 31, 2024
@worachate001 worachate001 self-assigned this Jan 31, 2024
@worachate001 worachate001 added the bug Something likely wrong in the code label Jan 31, 2024
Plugin automation moved this from To do to Done Mar 9, 2024
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Mar 10, 2024
Copy link

Hello @TheSuggestionGuy!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Mar 26, 2024
Copy link

Hello @TheSuggestionGuy!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something likely wrong in the code
Projects
Plugin
  
Done
Development

No branches or pull requests

3 participants