Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculates the eclipses #407

Closed
2 tasks done
alex-w opened this issue Sep 26, 2018 · 13 comments
Closed
2 tasks done

Calculates the eclipses #407

alex-w opened this issue Sep 26, 2018 · 13 comments
Assignees
Labels
wishlist Long-term ideas
Milestone

Comments

@alex-w
Copy link
Member

alex-w commented Sep 26, 2018

Original report: https://bugs.launchpad.net/stellarium/+bug/1106741

This feature request from old bug tracker.

It would be good that Stellarium can show and calculates the eclipses and the planets positions up to 100 years in the future and also in the past...like Redshift can do this.

Type of eclipses:

  • Lunar eclipses
  • Solar eclipses
@alex-w alex-w added wishlist Long-term ideas state: confirmed A developer can reproduce the issue labels Sep 26, 2018
@alex-w alex-w removed the state: confirmed A developer can reproduce the issue label Nov 19, 2020
@worachate001
Copy link
Member

Is anyone working on this issue or planning to do it soon?

It should be in "Astronomical Calculations", right?

@alex-w
Copy link
Member Author

alex-w commented Nov 19, 2021

Is anyone working on this issue or planning to do it soon?

The task in my TODO list, but not for near future

It should be in "Astronomical Calculations", right?

Yes

@worachate001
Copy link
Member

I'm working on the lunar eclipse. This is an example of what I have so far. You can search for lunar eclipses and go to the moment of greatest eclipse (Note: date and time are in my zone - UTC+7).

lunareclipseforstellarium

I'm using the icon from transit because I don't know how to add a new one for lunar eclipse (and still don't have it).

Hope to create a pull request soon for review and testing. After this, I will try to create something like this for solar eclipses.

@alex-w
Copy link
Member Author

alex-w commented Jan 19, 2022

See for example: https://github.com/Stellarium/stellarium/blob/master/data/gui/tabEclipses.png

@worachate001
Copy link
Member

In my draft of the pull request, it says worachate001 wants to merge 7 commits into Stellarium:master from worachate001:LunarEclipseCalc. It appears that the request include previous changes years ago. I'm not sure how to get rid or manage this situation (the changes look okay with just 3 files that I have made). If I go ahead with the pull request, it shouldn't be a problem, right?

@gzotti
Copy link
Member

gzotti commented Jan 19, 2022

In the tab "Files changed" we can see that 3 files were changed. the total number of commits is usually not important when we squash all changes into one commit on merge. Only large changes are merged as sequence of commits. But we need to review your work first :-)

@alex-w alex-w moved this from To do to In progress in Astronomical calculations (AstroCalc) Jan 20, 2022
@alex-w alex-w added this to the 0.22.0 milestone Jan 23, 2022
@worachate001
Copy link
Member

This is Solar Eclipses Tab for the AstroCalc. I believe this is enough for summary of the eclipse. I can write the code to find duration of totality/annularity, but it will take more time to calculate. Any suggestions are welcome.

solareclipses

@gzotti
Copy link
Member

gzotti commented Jan 26, 2022

Looks great, thank you. Now, for this tab, I wish to have another checkbox switch: double-clicking on one line should either move to point (and time) of greatest magnitude (TBD: What to do with time zone? Keep current, use LMST?), or should show greatest magnitude at my current location. The latter would of course require you can add local circumstances. (Bessel elements and so on.) The next big challenge would then be an earth map with shadow line (or adding a shadow line to the location panel's earth map) :-)

@alex-w
Copy link
Member Author

alex-w commented Jan 27, 2022

Well, I see in the new tab calculation greatest eclipses and their locations - I think the time for all of them should be UTC to avoid time zone misunderstanding. The coordinates should follow option "Use decimal degrees" to switch the representation of data - DMS or DD format. Cosmetic fix: the tabs should be at bottom to use homogeneous view of tools (see Graphs or PC tabs as examples).

Of course on the new tab we see "generic" data of solar eclipses. I think we next obvious step will be adding new tab for solar eclipses, where users will see eclipse circumstances for current location and these circumstances should be presented for visible eclipses only (for current location). For example user from Africa shouldn't see data for eclipse, which observable in Asia only.

@alex-w
Copy link
Member Author

alex-w commented Jan 27, 2022

I can write the code to find duration of totality/annularity, but it will take more time to calculate.

It would be helpful :)

@gzotti
Copy link
Member

gzotti commented Jan 27, 2022

This would then mean having two tabs: "Solar eclipses (global)" and "Solar eclipses (local)" with different double-click behaviour as suggested above.

@alex-w alex-w closed this as completed Jan 30, 2022
Astronomical calculations (AstroCalc) automation moved this from In progress to Done Jan 30, 2022
@alex-w alex-w added the state: fixed The bug has been fixed label Jan 30, 2022
@github-actions
Copy link

Hello @alex-w! Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: fixed The bug has been fixed label Mar 27, 2022
@github-actions
Copy link

Hello @alex-w! Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wishlist Long-term ideas
Development

No branches or pull requests

3 participants