Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong behaviour of Location Dialog #602

Closed
alex-w opened this issue Jan 20, 2019 · 1 comment · Fixed by #654
Closed

Wrong behaviour of Location Dialog #602

alex-w opened this issue Jan 20, 2019 · 1 comment · Fixed by #654
Assignees
@gzotti
Labels
bug Something likely wrong in the code importance: medium A bit annoying, minor miscalculation, but no crash
Projects
GUI
Milestone
0.19.0

Comments

@alex-w
Copy link
Member

alex-w commented Jan 20, 2019

Expected Behaviour

When user clicked on the list of locations then Stellarium should change the location and set time zone from location (if time zone is not user defined!) without changes the flag "Use custom time zone".

Actual Behaviour

When user clicked on the list of locations then Stellarium changes the location and set time zone from location via enforcement setting the time zone as "Use custom time zone" (with resetting all user settings!).

Last version with correct behaviour is 0.18.0.

Tested on Ubuntu Linux since version 0.17.0 to master.

Logfile

Not applicable here.
@alex-w alex-w added bug Something likely wrong in the code importance: medium A bit annoying, minor miscalculation, but no crash labels Jan 20, 2019
@alex-w alex-w added this to the 0.19.0 milestone Jan 20, 2019
@alex-w alex-w added this to To Do in GUI via automation Jan 20, 2019
@alex-w alex-w mentioned this issue Jan 22, 2019
Closed
gzotti added a commit that referenced this issue Mar 18, 2019
@gzotti
Fixes in the location panel. Should fix #602.
e8c092c 
- Refactored to better names.
- Preserve custom timezone setting.
@gzotti gzotti mentioned this issue Mar 18, 2019
Merged
15 tasks
@gzotti
Copy link
Member

gzotti commented Mar 20, 2019

Seems to be solved in #654, so far for terrestrial locations.

@gzotti gzotti added the state: fixed The bug has been fixed label Mar 21, 2019
GUI automation moved this from To Do to Done Mar 21, 2019
gzotti added a commit that referenced this issue Mar 21, 2019
@gzotti
Fix timezones mess (#654)
7c1c9f8 
Several fixes around time zone use.

* Fixes in the location panel. Should fix #602.
* Found a fix for #594 (weird time jumps in 1AD)
* Make custom time zone use a full property of StelCore
* Accept all possible timezones from our location database plus Qt's list.
* Preserve custom timezone setting.
* Scripting function enhancement
* Add display of used (terrestrial) timezone for observation from extraterrestrial locations.
* LocationDialog: Return to default location resets location list.
* Guide: describe timezone settings.
* Refactored to better names.
@alex-w alex-w removed the state: fixed The bug has been fixed label Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gzotti gzotti

Labels
bug Something likely wrong in the code importance: medium A bit annoying, minor miscalculation, but no crash
Projects
GUI
  
Done
Milestone
0.19.0
Development

Successfully merging a pull request may close this issue.

Fix timezones mess Stellarium/stellarium
2 participants
@alex-w @gzotti