Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support HTC 2.0 theory #1942

Merged
merged 5 commits into from
Oct 7, 2021
Merged

Added support HTC 2.0 theory #1942

merged 5 commits into from
Oct 7, 2021

Conversation

alex-w
Copy link
Member

@alex-w alex-w commented Sep 30, 2021

Description

Added support HTC 2.0 theory for compute positions of 3 moons of Saturn: Helene, Telesto and Calypso

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

…de planetarium)

Positions (in astronomical unit) and velocities (in astronomical unit per day) of Helene, Telesto, and Calypso (Lagrangian satellites of Dione and Tethys in Saturn's system) referred to the center of Saturn and to the mean ecliptic and mean equinox of J2000. From: "An upgraded theory for Helene, Telesto, and Calypso",   Oberti P., Vienne A., 2002, A&A
Visual fix for orbits of Helene, Telesto, and Calypso (Lagrangian satellites of Dione and Tethys in Saturn's system)
@github-actions
Copy link

github-actions bot commented Sep 30, 2021

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files

@alex-w alex-w added this to To do in Solar System via automation Sep 30, 2021
@gzotti
Copy link
Member

gzotti commented Oct 6, 2021

Great!
Move to Calypso, center Saturn, and see Tethys fixed in the West. :-)
On Telesto, Tethys is fixed in hour angle 21h.
On Helene, Dione does the same.

Apart from the cosmetics, I think it's fine.

@alex-w alex-w merged commit b9862ef into master Oct 7, 2021
@alex-w alex-w deleted the ephemerides/htc20-theory branch October 7, 2021 03:27
Solar System automation moved this from To do to Done Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Solar System
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants