Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Arabian Peninsula sky culture #2105

Merged
merged 4 commits into from
Dec 16, 2021
Merged

Fixes for Arabian Peninsula sky culture #2105

merged 4 commits into from
Dec 16, 2021

Conversation

kajaji
Copy link
Contributor

@kajaji kajaji commented Dec 16, 2021

Fix some typos and modify some English names of constellations and stars.

Description

  • Fix some typos in the description.en.utf8 and names_dictionary.md files
  • Modify names of some stars and constellations to be able to translate them back to their original Arabic strings
  • Split one sky culture to get the labels displayed clearly

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update

How Has This Been Tested?

Test Configuration:

  • Operating system: <Windows 10>
  • Graphics Card: <Manufacturer (likely Intel, NVidia, AMD?), Model (HD, Geforce, Radeon..., with model number), driver version?>

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Fix some English names to facilitate translating them back to original Arabic strings. The previous names are the same as in other sky cultures which forces the translation to have the same Arabic string in different contexts.

Constellation 4213 "Claws Of Al-Jawza" was split into two constellation for clearer display.
Fix some English names of stars to be able to translate them back to the original Arabic names.
@github-actions
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching skycultures/**:

  • Did you remember to update po/stellarium-skycultures/POFILES.in file respectively to changes in sky cultures?
  • Did you remember to update skycultures/CMakeLists.txt and skycultures/YOUR-SKYCULTURE-FOLDER/CMakeLists.txt files respectively to changes in sky cultures?
  • Did you remember to update util/skycultures/po4a.config file respectively to changes in sky cultures?
  • Did you remember to define classification parameter in sky cultures?

This is an automatically generated QA checklist based on modified files

Copy link
Member

@alex-w alex-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alex-w alex-w merged commit 60b8465 into Stellarium:master Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants