Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prism] Fix process timeouts between highlight calls for long building pages #138

Merged
merged 2 commits into from
Apr 25, 2022

Conversation

ogizanagi
Copy link
Member

@ogizanagi ogizanagi commented Apr 22, 2022

In case a page takes time to build and contains multiple highlight calls,
the time elapsed between 2 calls might be too long and the process might timeout (for instance, if there is a large amount of images to resize in the page).

Instead of using a global timeout for the process, let's use an idle timeout (time without any output) between each highlight call and reset it after getting a response from the Node process.

In case a page takes time to build and contains multiple highlight
calls,
the time elapsed between 2 calls might be too long and the process
timeout.
@ogizanagi ogizanagi changed the title [Prism] increment timeouts between highlight for long building pages [Prism] Fix process timeouts between highlight calls for long building pages Apr 25, 2022
@ogizanagi ogizanagi marked this pull request as ready for review April 25, 2022 09:01
@ogizanagi ogizanagi requested a review from Tom32i April 25, 2022 09:01
Copy link
Collaborator

@Tom32i Tom32i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ogizanagi ogizanagi merged commit 1974fd1 into master Apr 25, 2022
@ogizanagi ogizanagi deleted the prism-timeout branch April 25, 2022 11:35
@ogizanagi ogizanagi added the bug Something isn't working label Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants