[Builder] Decode URLs before dumping to file #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that the file path does not contains URL-encoded chars anymore, which would prevent serving them properly.
ogizanagi
force-pushed
the
builder-url-decode
branch
from
4d3184e
to
be97db8
Compare
benji07
approved these changes
Mar 1, 2023
Tom32i
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that the file path does not contains URL-encoded chars anymore,
which would prevent serving them properly.
I have an application that includes some PDFs files rendered through a controller, where the original file might contain spaces that would be encoded in the URL (
%20). Without this patch, the resulting file contains the encoded chars (e.g:recipes/stockholm%20mule.pdf). So once build statically, it cannot be served as expected.Bonus: 🍸