Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed docker container build error. #322

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

iratahack
Copy link
Contributor

@Stephane-D , I updated the install path for sjasm. The docker image build is passing now.

Copy link
Contributor

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though I have no rights here, I approve. Thank you for fixing this!

@joeyparrish
Copy link
Contributor

@iratahack, I have a more full-featured fix for that lowercase actor thing. I was waiting for your fix to land first, but I'll go ahead and upload the PR. You can incorporate the whole thing if you want.

@joeyparrish
Copy link
Contributor

See #323

@iratahack
Copy link
Contributor Author

@iratahack, I have a more full-featured fix for that lowercase actor thing. I was waiting for your fix to land first, but I'll go ahead and upload the PR. You can incorporate the whole thing if you want.

@joeyparrish , I'll back out my change for this and go with what you have.

@Stephane-D Stephane-D merged commit 1452913 into Stephane-D:master Apr 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants