Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request [Topic]
Added new feature to New-PSHTMLChart. Add the ability to transform the charts to base64 img in the html (when the html is executed for the moment ... )
Please tell us , the type of Change you are submiting:
Select one of the following:
Does it fix an existing issue? Please tell us which one
Related to the following issues: #221 #255 #220
Description of what's been changed
-Added a new switch
tobase64
to theNew-PSHTMLChart
-Added a new condition inside
New-PSHTMLChart
whenToBase64
is used. this will change the default value of theonComplete
event of the current chart to this:-Added a ChartAnimation class to add the animation option for chartoptions
-Added a new GetDefinition override in the chart class, this override add a javascript function called
RemoveCanvasAndCreateBase64Image
. The function to transform the chart into a base64, then create a new img tag in place of the canvas and delete the script tag associated with the chart ( #255 ).Results of your tests (If applicable)
No new test @ the moment, but i invite you to test on of your example i modified : 4charts.ps1 where all the new features proposed are exposed.
Edit:
@ the moment selnium is not implemented