Feature/backend openxr pollevent #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fantastic, this is looking really great! I'll have a few notes for you over on the code in a moment, and I'll try and give this a spin tomorrow :) |
maluoi
reviewed
Nov 8, 2022
|
Added |
|
Fantastic work once again! Thanks for this one, seems to work perfectly for me! |
maluoi
added a commit
that referenced
this pull request
Nov 15, 2022
This update merges in some big changes to the way the C# build scripts work! This allows for switching between the Oculus and Standard OpenXR Loader (for those _not_ targeting Quest!), as well as lays the groundwork for the upcoming Maui based multi-target template. Some projects _may_ experience issues upgrading due to this, especially if using the Universal template. If you see this in your project, I'd love to know, notes at the bottom about that. Here's the changelog: - Added auto-copy of Assets folder <SKCopyAssets>true/false, <SKAssetFolder>path, and <SKAssetDestination>path - Added auto-compile for shaders in the Assets folder. - Added ability to switch between the standard and Oculus version of the OpenXR Loader, <SKOpenXRLoader>. - Added support for multimaterial skinned meshes, thanks @holloway! #495 - Added `Tex.GenParticle`. - Added `Mesh.GenerateCircle`, and added `doubleSided` to `Mesh.GeneratePlane`, thanks @jackdaus! #503 - Added `Backend.OpenXR.OnPollEvent` to allow for more OpenXR extension implementations, thanks @jackdaus! #513 - Added `UI.Toggle` overload with sprite arguments. #514 - Added IntPtr overloads for `Sound.Read/WriteSamples`. - Removed Linux dependencies on libjsoncpp and libglew. #507 and #485 - Text material now uses DepthTest.LessEq, should help reduce z-fighting artifacts on far text. - Cmake now works with Android, thanks @malek! #516 - Fixed an issue with a missing library on UWP ARM via cmake, #501 - Fixed an issue with parsing certain URIs in GLTF files. - Fixed an issue with `Material.Copy` not copying material chaining. - Fixed an issue with the simulated hand's wrist joint not matching real hand data. - UI.Panel now uses the correct visual element. #484 Previously, asset copying was manually added to templates, this update adds some code that makes this no longer necessary. For existing projects, duplicate asset copying isn't a problem, but the Universal template did a bit extra in order to use a shared asset folder. Please see this branch of the Universal template for changes that you'll probably need! https://github.com/StereoKit/SKTemplate-Universal/tree/feature/v0.3.7_Asset_Copy
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the Backend.OpenXR.PollEvent callback for #493! Let me know if you want me to make any changes or add any specific test(s).
It was pretty tricky figuring out the C#/C interop since I didn't have much experience with that, but I think I got it figured it out. I did some local testing, and adding/removing callbacks seems to work as expected.
I also wanted to make sure this PR would work with my larger goal of implementing the FBSpatialEntity extensions, so I got a little initial demo of that over here: https://github.com/jackdaus/StereoKit/tree/feature/fb_spatial_entity_ext. It's just got the initial create anchor extension working, but I am planning on implementing most of the other pieces of this extension soon (like storing and querying anchors). I could also make a PR with that branch eventually if you think it's worth adding to SK.