Fix cMethods typo

[Msegade]

No description provided.

[coveralls]

Coverage remained the same at ?% when pulling a70a838 on Msegade:master into 8672243 on SteveDoyle2:master.

[coveralls]

Coverage remained the same at ?% when pulling a70a838 on Msegade:master into 8672243 on SteveDoyle2:master.

[SteveDoyle2]

Why is this a typo?

In bdf/bdf_interface/attributes.py, I see:
self.cMethods = {} # type: Dict[int, Any]

[Msegade]

Because it is written cmethods, not cMethods. Sorry if I'm missing something obvious here.

[SteveDoyle2]

Maybe I'm missing something, but why?

If it's going to change, it needs to be changed in all the places where it's used.

[Msegade]

If I define a complex methods in subcase 1 in my BDF file like this:
EIGC,1,HESS,MAX,,12
and I read the BDF using pynastran with:
model = BDF()
model.read_bdf(bdf_filename)
when I try to get the values using the CMethod method:
model.CMethods(1)
I get the error
AttributeError: 'BDF' object has no attribute 'cmethods'
Because as you pointed out, the attribute its defined as 'cMethods'.
So changing the name to 'cMethods' in the 'get_methods.py' file
(it is correct in other parts of the code), solves the issue.

[Msegade]

As I don't understand why you closed this. Can you please explain why this simple test fails? (I'm using one of the .bdfs in the models folder)

test.zip

[SteveDoyle2]

I thought you were going to update the pull request to update the name of the variable everywhere instead of just 1 place. That's why I didn't accept it right away.

It sat for 2.5 weeks, so I closed it.

I can look at the model later (I'm on my phone), but if you have a small test that fails that is ideally part of the commit and is tested to prevent future bugs.

[SteveDoyle2]

I don't see the message I just typed, so...

I ran your example and wow...my mistake. I completely misread that pull request.

I thought you changed the variable name from cMethods to cmethods and not the other way around.

[Msegade]

Ok, glad is now solved.