Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'enabled' parameter to set dynamically #259

Merged
merged 3 commits into from
Mar 31, 2023

Conversation

dujeong
Copy link
Contributor

@dujeong dujeong commented Mar 29, 2023

There was already a service that had a function similar to toggle stvl. (service name: <observation_topic>/toggle_enabled)
The service can be set up for each individual topic, but I wanted a toggle function for the entire stvl.

So I implemented the function and made it dynamically configurable.

I referred to the functions(activate, deactivate).

Copy link
Owner

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good

src/spatio_temporal_voxel_layer.cpp Outdated Show resolved Hide resolved
src/spatio_temporal_voxel_layer.cpp Outdated Show resolved Hide resolved
dujeong and others added 2 commits March 29, 2023 13:41
trivial

Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
@dujeong
Copy link
Contributor Author

dujeong commented Mar 30, 2023

@SteveMacenski
I added checking nullptr part in the code. Is that what you meant?

Copy link
Owner

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you tested this as working?

@dujeong
Copy link
Contributor Author

dujeong commented Mar 31, 2023

Sure! I tested it on the robot. It worked well. :)

@SteveMacenski SteveMacenski merged commit 359c006 into SteveMacenski:ros2 Mar 31, 2023
@SteveMacenski
Copy link
Owner

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants