Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GoogleTranslate.php #109

Merged
merged 1 commit into from
Jul 22, 2019
Merged

Update GoogleTranslate.php #109

merged 1 commit into from
Jul 22, 2019

Conversation

fcorbi
Copy link
Contributor

@fcorbi fcorbi commented Jul 11, 2019

Fix 400 BadRequest new release of google translate

Fix 400 BadRequest new release of google translate
@frzsombor
Copy link
Contributor

frzsombor commented Jul 12, 2019

Thanks for the super quick fix! I noticed your pull request before even noticing the problem on my server. Have you found the solution yourself or found it somewhere on the web? And do you have any background information on these changes?

@DONSA
Copy link

DONSA commented Jul 12, 2019

Not sure if this is still maintained anymore.
@fcorbi maybe you could make these changes in your fork?

@frzsombor
Copy link
Contributor

@DONSA: I do think this project is maintained, maybe you just have to wait a bit more than a few hours for @Stichoza to respond. :)

@DONSA
Copy link

DONSA commented Jul 12, 2019

Branch ^3.2 doesn't have the latest changes that were made 7 months ago.
But you are right, waiting 5110 hours is not enough 🙂

@frzsombor
Copy link
Contributor

frzsombor commented Jul 12, 2019

I'm not sure if not maintaining an old branch equals to not maintaining a project, but anyway if you need the latest changes you can find them in the latest release. But time (and hopefully Stichoza) will give you a better answer to this and to your opened issue.

@Stichoza Stichoza merged commit 6109b1e into Stichoza:master Jul 22, 2019
@Stichoza
Copy link
Owner

Sorry for being late. Merged. Thank you very much! 👍

@Stichoza Stichoza mentioned this pull request Jul 22, 2019
@fcorbi
Copy link
Contributor Author

fcorbi commented Jul 23, 2019

You're welcome @Stichoza! thank you for the repo

@frzsombor no i don't have any background information, only had a big bug on server 😢
@DONSA it's merged now, you can pull from here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants