Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump org.bouncycastle:bcpkix-jdk18on from 1.77 to 1.78.1 #1110

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 21, 2024

Bumps org.bouncycastle:bcpkix-jdk18on from 1.77 to 1.78.1.

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 21, 2024
@dependabot dependabot bot requested a review from Frooodle as a code owner April 21, 2024 22:07
@dependabot dependabot bot added the Java Pull requests that update Java code label Apr 21, 2024
Copy link

sonarcloud bot commented Apr 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@dependabot dependabot bot force-pushed the dependabot/gradle/org.bouncycastle-bcpkix-jdk18on-1.78.1 branch 2 times, most recently from 8d6ea0a to ff19178 Compare April 29, 2024 21:02
@dependabot dependabot bot force-pushed the dependabot/gradle/org.bouncycastle-bcpkix-jdk18on-1.78.1 branch from ff19178 to b7d95fd Compare May 5, 2024 19:51
@dependabot dependabot bot force-pushed the dependabot/gradle/org.bouncycastle-bcpkix-jdk18on-1.78.1 branch 4 times, most recently from 3af922d to 20162ce Compare May 19, 2024 22:27
Bumps [org.bouncycastle:bcpkix-jdk18on](https://github.com/bcgit/bc-java) from 1.77 to 1.78.1.
- [Changelog](https://github.com/bcgit/bc-java/blob/main/docs/releasenotes.html)
- [Commits](https://github.com/bcgit/bc-java/commits)

---
updated-dependencies:
- dependency-name: org.bouncycastle:bcpkix-jdk18on
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/gradle/org.bouncycastle-bcpkix-jdk18on-1.78.1 branch from 20162ce to 2330813 Compare May 20, 2024 17:47
Copy link

sonarcloud bot commented Jun 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@reneleonhardt
Copy link

I wonder why updates are not being (auto-) merged as soon as possible... 3 vulnerability fixes in this Cryptography PR alone:
https://mvnrepository.com/artifact/org.bouncycastle/bcpkix-jdk18on

@Frooodle
Copy link
Member

Frooodle commented Aug 4, 2024

Our automated tests do not currently test the features that use this dependency (cert signing)
We don't want to merge anything which will break functionality
Until we have a full test suite no auto merging will be happening

@reneleonhardt
Copy link

Instead of waiting for a full test suite you could manually test this, why do you think a minor dependency update is a breaking update? 🤔
Your users can only run a latest Docker image built 3 months ago containing 36 vulnerabilities which all have been fixed ready for the taking...

@Frooodle
Copy link
Member

Frooodle commented Aug 4, 2024

Anyone is welcome to manually test it for me :)

@Frooodle
Copy link
Member

Frooodle commented Aug 4, 2024

I do want to spend time getting these merged but this whole project is done in spare time
And since most users use this either locally or via VPN it has less priority to bugs

@reneleonhardt
Copy link

I know that most users don't appreciate all the work through donations 🙁
If it would be my project I would fix the dozens of bugs I know of easily (by [auto-] merging Dependabot updates) instead of waiting for bugs caused by updates which may never happen 😅

@Frooodle
Copy link
Member

Frooodle commented Aug 8, 2024

@reneleonhardt https://github.com/Stirling-Tools/Stirling-PDF/blob/main/build.gradle#L173 seems this was updated 2 months ago anyway by user and this is just bad conflict

@Frooodle Frooodle closed this Aug 8, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 8, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/gradle/org.bouncycastle-bcpkix-jdk18on-1.78.1 branch August 8, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants