Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Error after logging out and selecting another language #924

Merged
merged 2 commits into from
Mar 17, 2024

Conversation

Ludy87
Copy link
Contributor

@Ludy87 Ludy87 commented Mar 17, 2024

Description

When logging out, the language is passed as a parameter in the URL. When changing the language, the parameter is supplemented with ?lang= and should be replaced.

after logout: http://127.0.0.1:8080/login?logout=true&lang=de_DE
after logout and language change: http://127.0.0.1:8080/login?logout=true&lang=de_DE?lang=ca_CA

Should: http://127.0.0.1:8080/login?logout=true&lang=ca_CA

Checklist:

  • I have read the Contribution Guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

Contributor License Agreement

By submitting this pull request, I acknowledge and agree that my contributions will be included in Stirling-PDF and that they can be relicensed in the future under the MPL 2.0 (Mozilla Public License Version 2.0) license.

(This does not change the general open-source nature of Stirling-PDF, simply moving from one license to another license)

@Ludy87 Ludy87 requested a review from Frooodle as a code owner March 17, 2024 09:51
@Frooodle Frooodle merged commit 51bb26a into Stirling-Tools:main Mar 17, 2024
3 checks passed
@Ludy87 Ludy87 deleted the url_parameter branch August 19, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants