Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Icon #32

Closed
elijahverdoorn opened this issue Aug 7, 2016 · 14 comments
Closed

App Icon #32

elijahverdoorn opened this issue Aug 7, 2016 · 14 comments
Assignees
Milestone

Comments

@elijahverdoorn
Copy link
Contributor

This seems to be an easy tool to resize the icon:
https://makeappicon.com/

@hawkrives
Copy link
Member

Are we planning to re-use the existing icon, or go with something Oleville-related?

@elijahverdoorn
Copy link
Contributor Author

We're going with this one:
oleville-logo

@hawkrives
Copy link
Member

hawkrives commented Aug 8, 2016

It's round ⭕

@elijahverdoorn
Copy link
Contributor Author

True, but I think that having a bit of a white border on the iOS version is ok. It matches the trend set by apps like messenger, groupme, Twitter. The tool that I posted above will make the whitespace for us.

@drewvolz
Copy link
Member

drewvolz commented Aug 8, 2016

Yeah, our current set of iOS icons were made by that toaster. It's a cool site. I have a CLI tool for taking a high quality app icon and creating all of the other icon sizes. If I find that, I'll send it your way. It does look good after running it through makeappicon. I had to see it on the full device before I could make a comment.. Neat icon, nevertheless.

@elijahverdoorn
Copy link
Contributor Author

@drewvolz If you find that tool, I'd like a copy. I'll eventually get around to adding it to the project so that we can all look at it and voice opinions.

@drewvolz
Copy link
Member

I remembered incorrect -- it was for screenshots, which we do not have to worry about anymore. Apple recently sent out an email saying they now allow you to upload your highest quality screenshot (that fits their standards) and they will slice-n-dice as needed to fit the smaller screenshot sizes. So, never mind.

@hawkrives
Copy link
Member

@elijahverdoorn, mind if I take a stab at adding the icons to the build? I ran them through the tool you linked (I attached the output.)

logo copy.zip

@elijahverdoorn
Copy link
Contributor Author

Go for it.

On Aug 11, 2016 6:02 AM, "Hawken Rives" notifications@github.com wrote:

@elijahverdoorn https://github.com/elijahverdoorn, mind if I take a
stab at adding the icons to the build? I ran them through the tool you
linked (I attached the output.)

logo copy.zip
https://github.com/StoDevX/AAO-React-Native/files/413008/logo.copy.zip


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#32 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALfBznnLJaBI8NEuqfZnaTRmfze7JSdIks5qewE6gaJpZM4JenWi
.

@hawkrives
Copy link
Member

Done with 8bbf925.

@hawkrives hawkrives mentioned this issue Aug 12, 2016
2 tasks
@hawkrives hawkrives modified the milestone: v1.0 Aug 16, 2016
@drewvolz
Copy link
Member

drewvolz commented Aug 21, 2016

This is solved with #117

@drewvolz
Copy link
Member

drewvolz commented Sep 20, 2016

@elijahverdoorn the app icon preview on the iOS app store is the icon with a white background, but when downloaded, a black background. Would you be open to a PR in the near future to a white background on the icon?

@hawkrives
Copy link
Member

Aka "can we please change the iOS icon to a white background‽"

pretty please?

🎁🍨

@elijahverdoorn
Copy link
Contributor Author

@hawkrives @drewvolz I was taking a poll around here and people said they like the black, but I personally agree with you that the white would look better. I'd accept a PR for that change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants