Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate use of Moment's default options #807

Open
hawkrives opened this issue Mar 2, 2017 · 6 comments
Open

Investigate use of Moment's default options #807

hawkrives opened this issue Mar 2, 2017 · 6 comments

Comments

@hawkrives
Copy link
Member

We should look into using Moment.relativeTimeRounding and Moment.relativeTimeThreshold to control the global rounding needs expressed in #that-other-issue. (see also: http://stackoverflow.com/a/42520227/2347774)

As it turns out, Moment Timezone also supports a "default time zone". Which will let us show all of our moments in Central time without having that constant scattered over every file 😄

@drewvolz
Copy link
Member

drewvolz commented Mar 2, 2017

Great idea, @hawkrives

@drewvolz
Copy link
Member

drewvolz commented Mar 8, 2018

As it turns out, Moment Timezone also supports a "default time zone". Which will let us show all of our moments in Central time without having that constant scattered over every file

I'm not sure why we decided to define that more than once.

@hawkrives
Copy link
Member Author

I know that we're not using the default time zone because we decided that only some views should use Central time; others should use the device time. We could revisit that.

@drewvolz
Copy link
Member

drewvolz commented Mar 8, 2018

We should revisit that.

@hawkrives
Copy link
Member Author

Let's revisit that.

@drewvolz drewvolz added this to the v2.6 milestone Mar 8, 2018
@hawkrives hawkrives modified the milestones: v2.6, v2.7 Aug 18, 2018
@hawkrives hawkrives modified the milestones: v2.7.0, v2.next-ish Dec 18, 2018
@rye rye modified the milestones: v2.next-ish, v2.8.0 Feb 4, 2019
@rye
Copy link
Member

rye commented Sep 7, 2019

Triage: Can someone please find #that-other-issue and update what needs to happen here, or remove this from the v2.8.0 milestone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants