Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Momentary ceiling #1087

Merged
merged 2 commits into from May 19, 2017
Merged

Momentary ceiling #1087

merged 2 commits into from May 19, 2017

Conversation

hawkrives
Copy link
Member

This PR tells Moment to quit rounding minutes, so there are (for example) always 9 minutes between 5:21pm and 5:30pm.

By default, Moment changes minutes at the 45-second mark.

Appeases @drewvolz
Closes nothing

@hawkrives hawkrives mentioned this pull request May 19, 2017
Closed
drewvolz
drewvolz approved these changes May 19, 2017
View reviewed changes
Copy link
Member

@drewvolz drewvolz left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 :shipit:

@hawkrives hawkrives merged commit 2696548 into master May 19, 2017
@hawkrives
Copy link
Member Author

w00t!

@drewvolz
Copy link
Member

drewvolz commented May 19, 2017 •
edited

This closes #807 It does not close it.

@hawkrives hawkrives deleted the momentary-ceiling branch May 22, 2017 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewvolz drewvolz drewvolz approved these changes

@mattk410 mattk410 Awaiting requested review from mattk410

@elijahverdoorn elijahverdoorn Awaiting requested review from elijahverdoorn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hawkrives @drewvolz