Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode html entities in menu #810

Merged
merged 3 commits into from Mar 3, 2017
Merged

Decode html entities in menu #810

merged 3 commits into from Mar 3, 2017

Conversation

drewvolz
Copy link
Member

@drewvolz drewvolz commented Mar 2, 2017

This decodes html entities that appear on station names, item names and diet names. Dietary descriptions from the menu filter view showed text that said Aquarium's and this will change it to say Aquarium's.

Closes #805

Copy link
Member

@hawkrives hawkrives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm 👍 on the change. I just have one nitpick.

import {toLaxTitleCase} from 'titlecase'
import {tracker} from '../../analytics'
const CENTRAL_TZ = 'America/Winnipeg'


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this blank line, please.

@drewvolz drewvolz merged commit e227f6f into master Mar 3, 2017
@drewvolz drewvolz deleted the strip-html-from-diets branch March 3, 2017 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants