Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Updated timer triggers for zoning refactor #219

Merged
merged 3 commits into from
Apr 22, 2024
Merged

refactor: Updated timer triggers for zoning refactor #219

merged 3 commits into from
Apr 22, 2024

Conversation

Panzerhandschuh
Copy link

No description provided.

jason-e
jason-e requested changes Apr 20, 2024
View reviewed changes
fgd/brush/trigger/trigger_momentum_timer_checkpoint.fgd Outdated Show resolved Hide resolved
fgd/brush/trigger/trigger_momentum_timer_end.fgd Outdated Show resolved Hide resolved
fgd/brush/trigger/trigger_momentum_timer_stage.fgd Outdated Show resolved Hide resolved
fgd/brush/trigger/trigger_momentum_timer_stage.fgd Outdated Show resolved Hide resolved
fgd/brush/trigger/trigger_momentum_timer_stage.fgd Outdated Show resolved Hide resolved
fgd/brush/trigger/trigger_momentum_timer_start.fgd Outdated Show resolved Hide resolved
fgd/brush/trigger/trigger_momentum_timer_start.fgd Outdated Show resolved Hide resolved
fgd/brush/trigger/trigger_momentum_timer_start.fgd Outdated Show resolved Hide resolved
fgd/brush/trigger/trigger_momentum_timer_start.fgd Outdated Show resolved Hide resolved
fgd/brush/trigger/trigger_momentum_timer_cancel.fgd Outdated Show resolved Hide resolved
@jason-e
Copy link

jason-e commented Apr 20, 2024

Can probably go ahead and remove trigger_momentum_timer_stop as well.

@Panzerhandschuh Panzerhandschuh force-pushed the feat/timer-zone-refactor branch 2 times, most recently from e057ad3 to cbc9a69 Compare April 20, 2024 17:59
@Panzerhandschuh
Copy link
Author

Can probably go ahead and remove trigger_momentum_timer_stop as well.

Done

@Panzerhandschuh
Copy link
Author

@jason-e Should these entities have different names? Ex: zone_timer_start, zone_timer_checkpoint, etc.

@jason-e
Copy link

jason-e commented Apr 20, 2024

Yeah I like the idea of not starting with trigger_ since they aren't real entities and don't have the properties of other trigger entities. zone_timer_ seems good if you were thinking of renaming them.

@Panzerhandschuh Panzerhandschuh changed the base branch from master to feat/mom-0.10 April 22, 2024 01:43
@Panzerhandschuh Panzerhandschuh merged commit bd3f878 into StrataSource:feat/mom-0.10 Apr 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jason-e jason-e jason-e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Panzerhandschuh @jason-e