Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/ecs account settings #42

Merged
merged 2 commits into from
Dec 19, 2022
Merged

Feat/ecs account settings #42

merged 2 commits into from
Dec 19, 2022

Conversation

chrischildresssg
Copy link
Contributor

@chrischildresssg chrischildresssg commented Dec 19, 2022 •
edited
Loading

Change description

Add sensible default ECS account settings, including long ARN formats and Container Insights and remove the associated instructions from the README

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

N/A

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@chrischildresssg chrischildresssg self-assigned this Dec 19, 2022
DJKaswa
DJKaswa approved these changes Dec 19, 2022
View reviewed changes
Copy link

@DJKaswa DJKaswa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrischildresssg chrischildresssg merged commit 5a4116d into main Dec 19, 2022
@chrischildresssg chrischildresssg deleted the feat/ecs-account-settings branch December 19, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DJKaswa DJKaswa DJKaswa approved these changes

Assignees

@chrischildresssg chrischildresssg

Labels
Ready To Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrischildresssg @DJKaswa