Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Allow conditionally disable the encryption configuration #25

Conversation

jheison-rodriguez
Copy link
Contributor

@jheison-rodriguez jheison-rodriguez commented Feb 22, 2024

Change description

EPB client has set SCPs in some OUs that don't allow a change in the method encryption in the bucket not even define it in TF files; this change is to address that problem and allows disabling that configuration block in this module. It's not risky because each bucket has as a default method encryption SSE-S3.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@jheison-rodriguez jheison-rodriguez force-pushed the feature/allows-disable-bucket-encryption-configuration branch from 0a79b7f to b4263c0 Compare February 22, 2024 12:43
Copy link
Contributor

@wesleykirkland wesleykirkland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@fernandoPedraza-sg fernandoPedraza-sg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jheison-rodriguez , Below is the code to create an S3 bucket we are using:

module "s3_bucket_logging" {
source = "StratusGrid/s3-bucket-logging/aws"
version = "2.1.3"
name_prefix = var.name_prefix
name_suffix = "${local.name_suffix}-${var.region}"
input_tags = merge(local.common_tags, {})
}

Could you please point out what parameter would be used in the module definition to disable encryption?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize the use of the module with the new feature will be:

module "s3_bucket_logging" {
source = "StratusGrid/s3-bucket-logging/aws"
version = "2.1.3"
name_prefix = var.name_prefix
name_suffix = "${local.name_suffix}-${var.region}"
input_tags = merge(local.common_tags, {})
enable_encryption = false
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants