Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bzip2 download url #29

Merged
merged 3 commits into from
Feb 11, 2023
Merged

Conversation

hakonhagland
Copy link
Contributor

This fixes issue #28 for me.

Copy link
Member

@genio genio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to remove old versions from the sources.list file

@genio
Copy link
Member

genio commented Jan 30, 2023

The old link could be updated to reflect their current location: https://sourceware.org/pub/bzip2/bzip2-1.0.6.tar.gz

@hakonhagland
Copy link
Contributor Author

The old link could be updated to reflect their current location

@genio Good idea, I have updated the PR.

@genio
Copy link
Member

genio commented Jan 30, 2023

Apologies. I think I confused you because I didn't explain much.

You can have multiple versions listed in the sources.list file and just use the version you want in the actual build script, 5034. So, if you want to leave both 1.0.6 and 1.0.8 in the sources.list you can do that with no problem. If there's a good reason to move up from 1.0.6 to whatever the latest version is, you just add the new version to the list and change the build script to use the new version.

@hakonhagland
Copy link
Contributor Author

So, if you want to leave both 1.0.6 and 1.0.8 in the sources.list you can do that with no problem.

@genio So this is because of line 227:

(cd $SRCDIR && wget -nv -nc --no-check-certificate `grep -v '^#' $CURDIR/sources.list | grep $PACK | head -n 1`)

the head -n 1 will select the first match, right? Anyway, I am not sure I see a problem with the current sources.list in this PR. It has been updated to the correct URL now, right? Did you mean that I should leave the old http://www.bzip.org/1.0.6/bzip2-1.0.6.tar.gz in there too?

@genio
Copy link
Member

genio commented Jan 30, 2023

I meant you could leave both 1.0.6 and 1.0.8 in there. Where you removed https://github.com/StrawberryPerl/build-extlibs/pull/29/files#diff-b4e8afd31aa7fe64e519b78a18871c7af6444b9ad6986484a5d457d7693b2179L192 1.0.8, you could have the following.

in sources.list:

#### bzip2
#URL http://www.sourceware.org/
https://sourceware.org/pub/bzip2/bzip2-1.0.6.tar.gz
https://sourceware.org/pub/bzip2/bzip2-1.0.8.tar.gz

and then in 5034:

bzip2-1.0.8

OR

bzip2-1.0.6

Depending on what's needed

@hakonhagland
Copy link
Contributor Author

I meant you could leave both 1.0.6 and 1.0.8 in there.

Ok! good idea. I have updated the PR again.

@shawnlaffan
Copy link
Contributor

@genio - is there anything remaining to do on this PR? I think it can be merged.

@genio genio merged commit 0695f5a into StrawberryPerl:master Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants