You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Immediately prior to this the Governor is collected which deletes the Adaptor instance, so the Adaptor instance (passed as a hint) used in formatContextFinalizer() is no longer valid.
The issues I've seen are segfaults & hangs (waiting to lock an invalid mutex), and stability is much better removing the above mentioned call to 'adaptor->finish()'.
I'm not sure that this is the best fix for this issue though, which is why I've not submitted a pull request.
Thanks
The text was updated successfully, but these errors were encountered:
Hi,
I've seen a number of odd issues when using Beamcoder heavily, and I believe this is due to a 'use after free' issue in the following line of code - https://github.com/Streampunk/beamcoder/blob/master/src/format.cc#L3831
Immediately prior to this the Governor is collected which deletes the Adaptor instance, so the Adaptor instance (passed as a hint) used in formatContextFinalizer() is no longer valid.
The issues I've seen are segfaults & hangs (waiting to lock an invalid mutex), and stability is much better removing the above mentioned call to 'adaptor->finish()'.
I'm not sure that this is the best fix for this issue though, which is why I've not submitted a pull request.
Thanks
The text was updated successfully, but these errors were encountered: