-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Gnome's MediaKeys support to allow for controlling stremio using media keys #350
Conversation
Description of the solution:
|
Would it be possible to transfer this to the Windows version as well? Would be greatly appreciated |
Hi. Thank you for the contribution. Unfortunately this doesn't work on my PC. I tested it first before checking the code. So basically I get this messages in the console:
This was strange as I see error and then it says Started to dig into the issue I found this merge reqquest which explains why it's not working. I want to add two very important points.
I found an example implementation of MPRIS for Qt and QML which may help implementing this feature. If you are willing to implement MPRIS I will gladly review and merge the changes. If you don't have time we may eventually implement it but I am not giving any promises or estimates. Thank you again. |
@core1024 thank you for the feedback, i will try to implement it whenever i have some free time. |
I was looking into this as well and found https://github.com/hoyon/mpv-mpris which adds seamless support between MPRIS and MPV, which (as far as I remember and can tell with some quick sanity checks) Stremio uses. (through libmpv) Unfortunately, libmpv does not get that seamless integration. I can't say anything with certainty, but it'd likely be a lot less work to try to get Stremio's libmpv to work with mpv-mpris then have people just install that as an optional dependency then try to implement mpris by hand. It's definitely a suboptimal solution, but I just checked and given how seamless mpv-mpris seems to work, it might be a relatively quick and easy bodge that works well-enough. edit : FYI as an extremely sub-optimal user-side workaround if you install mpv-mpris and then rightclick inside of stremio and click "watch on MPV" media keys will, sort of, work. Pause/Play seems to work fine, but next and previous don't, and it just closes instead of playing the next episode automatically |
add support for media keys on gnome-based desktop environments, using gnome's dbus MediaKeys interface.