Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a long press option to the button module based on timeout. #418

Merged
merged 22 commits into from
Jul 7, 2023

Conversation

dexter21767-dev
Copy link
Member

@dexter21767-dev dexter21767-dev commented Jun 30, 2023

this makes a long press on mobile browser execute a function instead of the default popup menu when long-pressing an anchor. (fully working on ios safari and the PWA)

it's currently only used in video objects (series episodes) for watching or marking as watched.

documentation regarding the added CSS: Safari CSS Properties.

it was only tested on:

  • ios safari : working as expected.
  • ios PWA: working as expected.
  • ios firefox: working as expected.
  • ios chrome: working as expected, but the context menu of the thumbnail image appears (bad UX).
  • windows chrome: working as expected.
  • windows chrome with device mode: the "mark as watched" appears, but will disappear if stopped pressing directly without moving the mouse slightly first.

@dexter21767-dev dexter21767-dev added the enhancement New feature or request label Jun 30, 2023
@CLAassistant
Copy link

CLAassistant commented Jun 30, 2023

CLA assistant check
All committers have signed the CLA.

src/common/Button/Button.js Outdated Show resolved Hide resolved
src/common/Button/Button.js Outdated Show resolved Hide resolved
src/common/Button/Button.js Outdated Show resolved Hide resolved
@tymmesyde
Copy link
Member

Tested on Android / Desktop with Firefox and Chrome

tymmesyde
tymmesyde previously approved these changes Jul 3, 2023
@dexter21767-dev dexter21767-dev removed the request for review from TRtomasz July 3, 2023 13:17
src/common/Button/Button.js Outdated Show resolved Hide resolved
src/common/Button/Button.js Outdated Show resolved Hide resolved
src/routes/MetaDetails/VideosList/Video/Video.js Outdated Show resolved Hide resolved
src/routes/MetaDetails/VideosList/Video/styles.less Outdated Show resolved Hide resolved
src/common/Button/styles.less Outdated Show resolved Hide resolved
src/common/Button/styles.less Outdated Show resolved Hide resolved
@Stremio Stremio deleted a comment from unclekingpin Jul 5, 2023
@unclekingpin unclekingpin self-requested a review July 7, 2023 15:40
@tymmesyde tymmesyde merged commit d44f704 into development Jul 7, 2023
1 check passed
@dexter21767-dev dexter21767-dev deleted the mobile-LongPress branch July 7, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants