Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect intro route #429

Merged
merged 7 commits into from
Jul 24, 2023
Merged

Protect intro route #429

merged 7 commits into from
Jul 24, 2023

Conversation

unclekingpin
Copy link
Contributor

No description provided.

tymmesyde
tymmesyde reviewed Jul 21, 2023
View reviewed changes
Copy link
Member

@tymmesyde tymmesyde left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a user refresh the page with a guest login, it will redirect to intro
Not sure how we can prevent that or if we want to
Other than that it works fine !

@elpiel elpiel linked an issue Jul 21, 2023 that may be closed by this pull request
Able to access login screen when already logged-in #328
Closed
@TRtomasz
Copy link
Member

working good, except the guest user redirection

@unclekingpin
Copy link
Contributor Author

unclekingpin commented Jul 21, 2023 •
edited
Loading

That will be fixed today. converting the PR into draft in the mean time.
cc: @TRtomasz @tymmesyde

@unclekingpin unclekingpin marked this pull request as draft July 21, 2023 10:44
@unclekingpin unclekingpin marked this pull request as ready for review July 21, 2023 19:53
@unclekingpin
Copy link
Contributor Author

That will be fixed today. converting the PR into draft in the mean time. cc: @TRtomasz @tymmesyde

ready for a review again.

@tymmesyde tymmesyde merged commit fed8646 into development Jul 24, 2023
1 check passed
@tymmesyde tymmesyde mentioned this pull request Jul 24, 2023
Closed
@elpiel elpiel deleted the protect-intro-route branch July 25, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tymmesyde tymmesyde tymmesyde approved these changes

@TRtomasz TRtomasz Awaiting requested review from TRtomasz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Able to access login screen when already logged-in
3 participants
@unclekingpin @TRtomasz @tymmesyde