Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use strider_server_name instead of SERVER_NAME for hostname. #59

Closed
wants to merge 1 commit into from

Conversation

alexfernandez
Copy link
Contributor

Solves issue #55 (comment). The problem is that Strider is changing the env variable SERVER_NAME to strider_server_name here.

@knownasilya
Copy link
Member

Strider uses the values from rc, which parses the envs as 'strider_*' and we use the parsed value here: https://github.com/Strider-CD/strider/blob/e29f0f0466ec1dcbde60460e3d4159096ca61a5c/lib/libconfig.js#L68

@alexfernandez
Copy link
Contributor Author

You are right, it is working now even without this PR. Closing.

@knownasilya
Copy link
Member

I know it's complicated. Once I have time I plan on refactoring the config system to make it less convoluted and easier for first time users.

@alexfernandez
Copy link
Contributor Author

No problem. Thanks for your lightning quick support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants