add finegrained exceptions to client #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ntlind
approved these changes
Apr 29, 2024
| @@ -18,3 +23,77 @@ def __init__(self): | |||
| class ClientConnectionFailed(Exception): | |||
| def __init__(self, msg: str): | |||
| super().__init__(msg) | |||
|
|
|||
|
|
|||
| class ServiceUnavailable(ClientException): | |||
There was a problem hiding this comment.
would it make sense to copy the docstrings from the /api exception classes to these classes for clarity? The docstring for this one would be "Raises an exception if the Valor service is unavailable."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beyond adding finegrained exceptions to the client as outlined in #482 , this PR
get_datasetorget_predictionare requested on things that don't exist, instead of returningNonewe raise an exception