Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added node specific constant force #3

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ansue1234
Copy link
Contributor

  • Added nonUniformConstantForce class to apply constant force at a node in a limb
  • Added various bash files to simplify compilation running different examples and running custom robots

Copy link
Collaborator

@QuantuMope QuantuMope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say to remove the added shell scripts. They don't seem useful other than the very first compile, which after that, you'd want to solely use dismech.sh and make changes from within robotDescription.cpp instead of in other git tracked files.

For the nonUniformConstantForce class. First, we can rename this to nodeConstantForce since nonUniform is an umbrella term for other types of force applications.

Second, how does the code run if you feed as input nodes of limbs that have been attached to existing joints. Such nodes actual refer to the joint node that exists in the original limb the joint was created on. Not handling this properly sounds like it would lead to bugs to me. Try it out. What I expect to see is the force doesn't do anything at all in these scenarios.

@QuantuMope QuantuMope added the enhancement New feature or request label Nov 3, 2023
@QuantuMope
Copy link
Collaborator

Looking at nonConstantForce.cpp, I see a triple nested for loop for conducting logic that can just be done once at initialization. This should be optimized.

Function add_force_to_limb_node can be changed to camel case: addForceToLimbNode.

I am still a proponent of removing all the shell scripts and customBot.cpp. Having the user copy from a preexisting example forces them to become familiar with the API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants