Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Into trash icon not disable #2087

Closed
CodeLyokoXtEAM opened this issue Jul 2, 2017 · 4 comments
Closed

Into trash icon not disable #2087

CodeLyokoXtEAM opened this issue Jul 2, 2017 · 4 comments
Assignees
@nao-pon
Labels
client bug

Comments

@CodeLyokoXtEAM
Copy link
Contributor

After referring page default disable trash icon in toolbar.
if select file or folder its enable normally.
But after dissected file and folder its still Remaining enable icon in toolbar.
@nao-pon nao-pon self-assigned this Jul 3, 2017
@nao-pon
Copy link
Member

nao-pon commented Jul 3, 2017

@CodeLyokoXtEAM When do not display the rm icon on the toolbar, a JavaScript error will occur, so I'll fix it.

@CodeLyokoXtEAM
Copy link
Contributor Author

CodeLyokoXtEAM commented Jul 3, 2017 •
edited

Also enable text label and refresh page. You can see delete icon lable is show cmdundifind while loading.

@CodeLyokoXtEAM
Copy link
Contributor Author

CodeLyokoXtEAM commented Jul 3, 2017 •
edited

I think this get ideas from this Interface & futures to improve elfinder.
https://github.com/kalcaddle/KodExplorer
http://demo.kalcaddle.com

@nao-pon nao-pon closed this as completed in 3d8e767 Jul 3, 2017
nao-pon added a commit that referenced this issue Jul 3, 2017
@nao-pon
[cmd:rm] fix #2087 button icon label is wrong until boot up
6f2afc1
@nao-pon
Copy link
Member

nao-pon commented Jul 3, 2017

@CodeLyokoXtEAM Thanks! About UI, It's future topics of discussion.

@CodeLyokoXtEAM CodeLyokoXtEAM mentioned this issue Aug 5, 2017
Closed
@nao-pon nao-pon reopened this Aug 5, 2017
@nao-pon nao-pon closed this as completed in 098c062 Aug 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nao-pon nao-pon

Labels
client bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nao-pon @CodeLyokoXtEAM