Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmd:help] controling to show / hide toolbar icons in preference tab #2118

Closed
nao-pon opened this issue Aug 2, 2017 · 10 comments
Closed

[cmd:help] controling to show / hide toolbar icons in preference tab #2118

nao-pon opened this issue Aug 2, 2017 · 10 comments
Assignees
Labels

Comments

@nao-pon
Copy link
Member

nao-pon commented Aug 2, 2017

In title.

@nao-pon nao-pon self-assigned this Aug 2, 2017
@nao-pon nao-pon added the feature label Aug 2, 2017
@CodeLyokoXtEAM
Copy link
Contributor

CodeLyokoXtEAM commented Aug 2, 2017

also how about add selection to auto hide or not on startup toolbar & navigation panel in mobile view

@nao-pon
Copy link
Member Author

nao-pon commented Aug 3, 2017

@CodeLyokoXtEAM

selection to auto hide or not on startup toolbar

The previous state is restored for the show/hide status of toolbar.

navigation panel

What is it like?

@CodeLyokoXtEAM
Copy link
Contributor

CodeLyokoXtEAM commented Aug 3, 2017

Edited:-
Also in mobile browser
Available option for 'The previous state is restored for the show/hide status of toolbar.'(default set)
If someone disable it. User can decide to auto hide or not on startup toolbar & navigation panel (tree view) separately.

Also Ticks are re-arrangement for better look.

@CodeLyokoXtEAM
Copy link
Contributor

If someone disabled all icons toolbar is hide. So computer can only reach settings by F1(right click options are not working(toolbar settings)). But mobile F1 option not available also long click & reach the settings is too hard.

@nao-pon nao-pon reopened this Aug 3, 2017
@nao-pon nao-pon closed this as completed in 6cf34da Aug 3, 2017
@nao-pon
Copy link
Member Author

nao-pon commented Aug 3, 2017

@CodeLyokoXtEAM Thanks a lot !. 👍

Preservation of the previous value in the initial state of the tool bar show / hide is always enabled at present. (It can not be invalidated) I can not think of the situation of the request that the installer wants to invalidate it...

However, I'll be waiting for you if there is a better proposal.

Thanks!

@CodeLyokoXtEAM
Copy link
Contributor

CodeLyokoXtEAM commented Aug 3, 2017

there is preference 3 tabs available

every reset multipli preference tab like this

image

image

@nao-pon
Copy link
Member Author

nao-pon commented Aug 3, 2017

It was my simple mistake and it has already been fixed (deb02bd).

Thanks!

@CodeLyokoXtEAM
Copy link
Contributor

how about if user disable all icon then add preferences settings icon to right click menu list. without add icon to tool bar.

@nao-pon
Copy link
Member Author

nao-pon commented Aug 4, 2017

That's nice! I'll try it. I think that it is better to always display it in the context menu. And, I think that the automatic display on the tool bar is optional.

nao-pon added a commit that referenced this issue Aug 4, 2017
```javascript
// toolbar extra options
toolbarExtra : {
	// also displays the text label on the button (true / false)
	displayTextLabel: false,
	// Exclude `displayTextLabel` setting UA type
	labelExcludeUA: ['Mobile'],
	// auto hide on initial open
	autoHideUA: ['Mobile'],
	// show Preference button ('none', 'auto', 'always')
	// If you do not include 'preference' in the context menu you should specify 'auto' or 'always'
	showPreferenceButton: 'none'
},
```

c.f #2118 - #2118 (comment)
@nao-pon
Copy link
Member Author

nao-pon commented Aug 4, 2017

@CodeLyokoXtEAM I done. Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants