Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom checkbox column does not show tick on mobile/Safari #2694

Closed
ghigio2000 opened this issue Oct 6, 2018 · 15 comments
Closed

Custom checkbox column does not show tick on mobile/Safari #2694

ghigio2000 opened this issue Oct 6, 2018 · 15 comments
Assignees

Comments

@ghigio2000
Copy link

@nao-pon

Hi, I completed my implementation of these checkbox (input.elfinder-cwd-list-chk) and they works ok on PC. But testing on mobile they are not showing the tick (checked symbol) when checked (it looks like they are disabled, but in reality the bootCallback works).
Can you fix it?
thanks

@ghigio2000 ghigio2000 changed the title Custom checkbox column does not show ticks on mobile Custom checkbox column does not show tick on mobile Oct 6, 2018
@nao-pon
Copy link
Member

nao-pon commented Oct 6, 2018

@ghigio2000 This is related with #2653 (comment). I'll fix it. Thanks! 👍

@nao-pon nao-pon self-assigned this Oct 6, 2018
@ghigio2000
Copy link
Author

thanks so I will close this

nao-pon added a commit that referenced this issue Oct 6, 2018
@ghigio2000
Copy link
Author

I thought this was fixed but it is not.
I have downloaded the last nightly build but I still see this problem using safari both on mobile as well as in the desktop.
Please let me know, thanks.

@ghigio2000 ghigio2000 reopened this Oct 12, 2018
@ghigio2000 ghigio2000 changed the title Custom checkbox column does not show tick on mobile Custom checkbox column does not show tick on mobile/Safari Oct 12, 2018
@nao-pon
Copy link
Member

nao-pon commented Oct 14, 2018

@ghigio2000 I tried it on iPhone 6s + iOS 12.0, but there is nothing wrong with it. However, since the touch point is sensitive, I think it would be better to take measures such as setting a margin in the check box.
fa7a6577-bbb5-452d-95b4-e7dc4134d63e

@nao-pon nao-pon closed this as completed Oct 15, 2018
@ghigio2000
Copy link
Author

ghigio2000 commented Oct 15, 2018

I updated using the last night library, but I am still having the same problem using Safari (not only with the touch but also on the PC using the mouse).
The callback works but it is not showing the tick on the square.
If I use Firefox everything is ok.
Could you please give a try to this:

http://globalterramaps.com/TerraVENEW.html?GEC=5

thanks.

@nao-pon
Copy link
Member

nao-pon commented Oct 15, 2018

I checked on iPhone 6s iOS 12.0.1 Safari. Column size are strange a little but display and operation are no problems.

15b0473e-5d3e-40d5-8680-777b6c218c2e

@ghigio2000
Copy link
Author

ghigio2000 commented Oct 23, 2018

@nao-pon
I am sorry to reply so late, but I did not get any notification about your answer above.
I am still having the same problem.
In the screen shot above I do not see any checkbox ticked.
Can you please tick one and resend me the screen shot?

We use iPhone 7, iPad, iPad Pro, iPhone 8 with different iOS version, including 12.0.1 and also we used Safari from PC Mac, but NONE of them are able to tick these checkboxs. The operation work but the checkbox is not ticked.

Please let me know, I am really sorry having completed my project and I cannot publish it for this reason.
Thanks as usual for your help.

@nao-pon
Copy link
Member

nao-pon commented Oct 23, 2018

  • First item (pippo folder) checked
    233ea96f-240b-4645-9ab0-89aa4b10c9cb

  • Second item (BHavCove.gpx)
    22db7b1c-70ac-464d-971a-6f0e36f45549

@ghigio2000
Copy link
Author

@nao-pon

At this point I do not understand anymore how can this be possible.
Do you think it is a matter of our Safari configuration?
Are you using Safari? I am asking just to be sure.

@ghigio2000
Copy link
Author

Sorry, I am able to reproduce your situation. I am sure I can fix it now.
Sorry again.

@nao-pon
Copy link
Member

nao-pon commented Oct 23, 2018

@ghigio2000 Perhaps by increasing the padding size of the checkbox on touch devices I think that erroneous touch can be prevented. For touch devices, elFinder nodes are given the "elfinder-touch" class.

@ghigio2000
Copy link
Author

@nao-pon mine seems to be a Safari checkbox problem.
In a particular situation I check/uncheck programmatically those checkbox.
It works in Firefox works this command
checkbox.checked=true or false
With Safari it is not working.

@ghigio2000
Copy link
Author

In you comments above you mentioned there are strange column size, how can I set a column size programmatically?

@nao-pon
Copy link
Member

nao-pon commented Oct 23, 2018

There is no problem in my test environment, so CSS of your environment may be affecting. Usually the column size will not be shifted. Since the column size is calculated according to the header line, there is a possibility that a problem may have occurred in acquiring the header size.

@ghigio2000
Copy link
Author

I now fixed all about the checkbox thanks a lot.

You mean I cannot change column size programmatically?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants