-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom checkbox column does not show tick on mobile/Safari #2694
Comments
@ghigio2000 This is related with #2653 (comment). I'll fix it. Thanks! 👍 |
thanks so I will close this |
I thought this was fixed but it is not. |
@ghigio2000 I tried it on iPhone 6s + iOS 12.0, but there is nothing wrong with it. However, since the touch point is sensitive, I think it would be better to take measures such as setting a margin in the check box. |
I updated using the last night library, but I am still having the same problem using Safari (not only with the touch but also on the PC using the mouse). http://globalterramaps.com/TerraVENEW.html?GEC=5 thanks. |
@nao-pon We use iPhone 7, iPad, iPad Pro, iPhone 8 with different iOS version, including 12.0.1 and also we used Safari from PC Mac, but NONE of them are able to tick these checkboxs. The operation work but the checkbox is not ticked. Please let me know, I am really sorry having completed my project and I cannot publish it for this reason. |
At this point I do not understand anymore how can this be possible. |
Sorry, I am able to reproduce your situation. I am sure I can fix it now. |
@ghigio2000 Perhaps by increasing the padding size of the checkbox on touch devices I think that erroneous touch can be prevented. For touch devices, elFinder nodes are given the "elfinder-touch" class. |
@nao-pon mine seems to be a Safari checkbox problem. |
In you comments above you mentioned there are strange column size, how can I set a column size programmatically? |
There is no problem in my test environment, so CSS of your environment may be affecting. Usually the column size will not be shifted. Since the column size is calculated according to the header line, there is a possibility that a problem may have occurred in acquiring the header size. |
I now fixed all about the checkbox thanks a lot. You mean I cannot change column size programmatically? |
@nao-pon
Hi, I completed my implementation of these checkbox (input.elfinder-cwd-list-chk) and they works ok on PC. But testing on mobile they are not showing the tick (checked symbol) when checked (it looks like they are disabled, but in reality the bootCallback works).
Can you fix it?
thanks
The text was updated successfully, but these errors were encountered: