Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css: need mini fix for spinner #2748

Closed
johnfort opened this issue Oct 26, 2018 · 4 comments
Closed

css: need mini fix for spinner #2748

johnfort opened this issue Oct 26, 2018 · 4 comments
Assignees

Comments

@johnfort
Copy link

johnfort commented Oct 26, 2018

open: elFinder/css/dialog.css
see line: 147 (.elfinder-spinner) and 475 (.elfinder-info-spinner)
remove lines: 475-481
replace lines 147-154 to:

.elfinder-spinner,
.elfinder-info-spinner {
display: inline-block;
margin: 0 5px;
width: 14px;
height: 14px;
background: url("../../img/scripts/elfinder/spinner-mini.gif") center center no-repeat;
vertical-align: inherit;
}

default

Why do this? see next..

default

remove lines: 462-464

And add

.elfinder-rtl .elfinder-info-tb tr td:first-child {
text-align: left;
}

@johnfort
Copy link
Author

johnfort commented Oct 30, 2018

@nao-pon add class .elfinder-spinner for:
.elfinder-resize-spinner
.elfinder-navbar-spinner

Restructure resize-spinner as .elfinder-spinner-text

@nao-pon
Copy link
Member

nao-pon commented Oct 30, 2018

@johnfort "elfinder-navbar-spinner" will be integrated into "elfinder-spinner". On the other hand, since "elfinder-resize-spinner" is actually a progress bar, it will not be integrated. Thanks!

@johnfort
Copy link
Author

johnfort commented Oct 30, 2018

@nao-pon All that is undefined, abstract, is a spinner. In fact, the progress bar is not used anywhere =)
Then rename "elfinder-resize-spinner" by analogy with dialogs.

@nao-pon
Copy link
Member

nao-pon commented Oct 31, 2018

@johnfort I'll change CSS class name elfinder-resize-spinner to elfinder-resize-loading.

nao-pon added a commit that referenced this issue Oct 31, 2018
nao-pon added a commit that referenced this issue Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants