rename update event to previewupdate because of conflict with prototype #2346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nao-pon
reviewed
Jan 4, 2018
| @@ -122,7 +122,8 @@ | |||
| } | |||
| .elfinder-quicklook-titlebar-icon .ui-icon { | |||
| position: relative; | |||
| margin: -9px 3px 0px 0px; | |||
| margin: 0px 3px 0px 0px; | |||
| display: inline-block; | |||
There was a problem hiding this comment.
What kind of problem are you having? Is there a screenshot of the problem?
There was a problem hiding this comment.
When I checked, the display position shifts downward due to this change.
There was a problem hiding this comment.
If your amendment is valid for plain elFinder, please make another branch and send it as a separate pull request.
|
@vcordes79 The event name "update" can not be changed easily because there are cases where other users have added the quicklook preview plugin by themselves. Instead, I will modify it to change the event name if Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still need prototype js for my app and could not use elfinder because of a conflict with the name of the update event. So I renamed the event to previewupdate. Please integrate the change into mainstream version.
Also I added an option to use ViewerJS as preview for pdf files in quicklook and fixed the quicklook close / dock button alignment