Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option onDropWith for plugin function iaEnabled #2442

Merged
merged 2 commits into from Mar 26, 2018

Conversation

nmpetkov
Copy link
Contributor

It is handy in some cases plugins (AutoResize, AutoRotate, Watermark) to be enabled, but to function only if given meta key is pressed while dropping images. This is opposite to option offDropWith.

This PR adds such a possibility.

Current functionality (offDropWith) is same and new features are backward compatible.

@nao-pon nao-pon merged commit f1c59f6 into Studio-42:master Mar 26, 2018
@nao-pon
Copy link
Member

nao-pon commented Mar 26, 2018

@nmpetkov It's so nice idea! Thanks! 👍

@nmpetkov
Copy link
Contributor Author

Thanks!
It is good to think then about something like check boxes (in toolbar?) to turn respective plugin on/off.
Then resizing, rotation and watermark can function not only when dropping images, but also when uploading by selecting with explorer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants