[FR]: config creates full path if it doesn't exist

[jonoff]

Is your feature request related to a problem? Please elaborate.

The recycle bin config variable is always treated as a subfolder of remote_dir, and when specifying a full path it is stripped to it's basename, which becomes the last folder of a full path:

qbit_manage/modules/config.py

Line 412 in 30c3bea

self.remote_dir, os.path.basename(self.data["directory"]["recycle_bin"].rstrip(os.sep))

Describe the solution you'd like

The example config and comment indiciate it's used an the full path
# <OPTIONAL> recycle_bin var: </your/path/here/> # Path of the RecycleBin folder. Default location is set to remote_dir/.RecycleBin

Instead of joining paths, just treat it as a full path when specified.

Does your solution involve any of the following?

• New config option
• New command option

Describe alternatives you've considered

The default may be a subfolder, but why limit it in this way?

Who will this benefit?

Any custom configurations

Additional Information

No response

[bobokun]

It's not limited. If you specify full path it should work. Did you test and verify it's not working with the full path?

[jonoff]

Yes, checking a recent log, it matches the code as it's only using the "basename" instead of /full/path/to/basename_bin
I see

Moved 1 files to [remote_dir]/[basename_bin]

[jonoff]

Looks like orphaned directory also is limited to be
a sub-directory, but I did not test this one:

qbit_manage/modules/config.py

Lines 397 to 400 in 30c3bea

	if self.commands["rem_orphaned"]:
	if "orphaned_dir" in self.data["directory"] and self.data["directory"]["orphaned_dir"] is not None:
	default_orphaned = os.path.join(
	self.remote_dir, os.path.basename(self.data["directory"]["orphaned_dir"].rstrip(os.sep))

[bobokun]

The code that you shared is only specifying the default recycle path and default orphaned path. Those are being used as default when the user does not specify. I just tested this and it's working correctly with specifying the exact path. It will use the default if the folder you specified does not exist or is not accessible. That's probably why you are seeing it use the default recycle directory.

[jonoff]

Interesting, most likely permission issue on my setup I'll check into.

Instead of the original default being used, since it overrides the default to include the basename of what I specified, this wasn't what I expected when the full path is inaccessible and I didn't see any related error.

[bobokun]

yeah I can add additional logs. In case you're wondering, the code that does the check to see if the folder exists is found here:

qbit_manage/modules/util.py

Lines 181 to 183 in 9e621e3

	elif var_type == "path":
	if os.path.exists(os.path.abspath(data[attribute])):
	return os.path.join(data[attribute], "")

[jonoff]

I'm also wondering what the reasoning is to override the default ".RecycleBin" to instead point to the basename of a specified path, if the full path is not accessible.

Permissions look correct but looking deeper now.

[bobokun]

I'm also wondering what the reasoning is to override the default ".RecycleBin" to instead point to the basename of a specified path, if the full path is not accessible.

It's because of #77, Not everyone might want the name .RecycleBinas the folder name. Taking the basename will keep the folder name of your preferred RecycleBin that you define in your configuration and put it in your root directory if the location you specified cannot be found.

What is currently set in your config.yml under directory?

[jonoff]

I was trying to reuse my NAS' recycle bin path. Dug a little deeper and looks like my issue resulted from the difference of how the full path is treated vs. the default: For the full path check, it's never created and only checked for existence, but the basename path is created when it doesn't exist already. I was assuming the full path would be created as well. the basename path being created silently led to my confusion.

qbit_manage/modules/util.py

Lines 181 to 185 in 9e621e3

	elif var_type == "path":
	if os.path.exists(os.path.abspath(data[attribute])):
	return os.path.join(data[attribute], "")
	else:
	message = f"Path {os.path.abspath(data[attribute])} does not exist"

This warning message used to be silently dropped before your new commit, since one of the branches returned before printing any message.

I'd consider this issue resolved with 2 more minor improvements:

1. Update the documentation to include an example of using the basename vs full path
2. run makedirs on full paths and surface any errors during creation, before resorting to using/creating default (basename) paths if the full ones don't exist, treating both similar to:

706821f#diff-c39b942d8f8620d46d314db8301189b8d6195fc97aedbeb124a33694b738d69cR202-R203

[bobokun]

Can you test the new develop branch? It should create the Recycle Bin folder now for the path you specified.

[jonoff]

Can you test the new develop branch? It should create the Recycle Bin folder now for the path you specified.

I'm running hotio's container image, I can try the nightly tag but doesn't seem to have a develop tag.

[bobokun]

Yes, hotios nightly tag points to develop branch

[jonoff]

Yep, just verified on :nightly, it created Recycle Bin at the full path specified.