Don't generate subfolders. #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Stuk#130, see this issue for more informations.
|
@SheetJSDev could you try this PR out and confirm that it fixes your issue? |
|
@SheetJSDev I've updated the generated files here (that will be easier to test). |
|
@dduponchel @Stuk looks good :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #130 for more.
The automatic sub-folder creation feature doesn't add any value (every archive manager create sub folders, even Windows "compressed folder" feature !) but creates issues when the content of the zip file doesn't represent files and folders (xlsx files for example).