Don't include the Buffer polyfill in dist/ files. #158
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a browser, there are multiple implementations of nodejs' Buffer. If we let browserify includes its own, we won't play nicely with the others (it uses
instanceof
and doesn't accept other implementations).With this patch, we don't include any implementation but we let the environment provides (or not) the Buffer.
This pull request includes #140 (fixing #139 too) and the fix I prepared. I got no response from @humphd so I assume he's ok with it :)