Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pako dependency #261

Merged
merged 1 commit into from
Feb 29, 2016
Merged

Update pako dependency #261

merged 1 commit into from
Feb 29, 2016

Conversation

puzrin
Copy link
Contributor

@puzrin puzrin commented Feb 27, 2016

Would be nice to release if possible, to use the same pako version across different projects.

@dduponchel
Copy link
Collaborator

I think we should use a ~1.0.0 instead of ^1.0.0. Our website advertises that JSZip is tested with nodejs 0.8 (well...) but the support of ^ was added in node 0.10.26. The travis build can't work on node 0.8 because of dependencies of devDependencies using a ^ (and a ^ our devDependencies) but npm install jszip should work.

The ^ version range is now nearly everywhere and if we can't test in node 0.8 maybe we should drop its support. Which means breaking things for those using node 0.8, so a major version bump in my opinion.

@puzrin
Copy link
Contributor Author

puzrin commented Feb 28, 2016

Yep, sir :)

changed ^ to ~

@puzrin
Copy link
Contributor Author

puzrin commented Feb 28, 2016

About node versions. I'd recomment to drop nodes < 4.0 in next major release (3.0.0). In 2.+ it worth to keep everything unchanged.

@dduponchel
Copy link
Collaborator

Thanks :)

dduponchel added a commit that referenced this pull request Feb 29, 2016
@dduponchel dduponchel merged commit 4fd4fc1 into Stuk:master Feb 29, 2016
@puzrin
Copy link
Contributor Author

puzrin commented Mar 3, 2016

Could you publish?

@dduponchel
Copy link
Collaborator

I'll see with @Stuk for a release.

@dduponchel dduponchel mentioned this pull request Mar 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants