Update pako dependency #261

Merged
merged 1 commit into from Feb 29, 2016

Projects

None yet

2 participants

@puzrin
Contributor
puzrin commented Feb 27, 2016

Would be nice to release if possible, to use the same pako version across different projects.

@dduponchel
Collaborator

I think we should use a ~1.0.0 instead of ^1.0.0. Our website advertises that JSZip is tested with nodejs 0.8 (well...) but the support of ^ was added in node 0.10.26. The travis build can't work on node 0.8 because of dependencies of devDependencies using a ^ (and a ^ our devDependencies) but npm install jszip should work.

The ^ version range is now nearly everywhere and if we can't test in node 0.8 maybe we should drop its support. Which means breaking things for those using node 0.8, so a major version bump in my opinion.

@puzrin
Contributor
puzrin commented Feb 28, 2016

Yep, sir :)

changed ^ to ~

@puzrin
Contributor
puzrin commented Feb 28, 2016

About node versions. I'd recomment to drop nodes < 4.0 in next major release (3.0.0). In 2.+ it worth to keep everything unchanged.

@dduponchel
Collaborator

Thanks :)

@dduponchel dduponchel merged commit 4fd4fc1 into Stuk:master Feb 29, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@puzrin
Contributor
puzrin commented Mar 3, 2016

Could you publish?

@dduponchel
Collaborator

I'll see with @Stuk for a release.

@dduponchel dduponchel referenced this pull request Mar 22, 2016
Merged

Release v2.6.0 #272

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment