New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JSZip v3] Blob, Promise and more. #275

Merged
merged 7 commits into from Apr 11, 2016

Conversation

Projects
None yet
1 participant
@dduponchel
Collaborator

dduponchel commented Mar 31, 2016

This pull request adds several things:

On features,

  • Blob and Promise support in loadAsync() and file()
  • support and tests for JSZip.external
  • support for async("array")

On

  • enforcing rules in JSHint
  • some documentation fixes
  • upgrade some dependencies
  • improve an error message

This should cover the remaining bullet points of #224.

dduponchel added some commits Apr 9, 2015

Accept Blob and Promise.
The methods `.file(name, data)` and `.loadAsync(data)` now accept Blob
and promises of supported types (string, Uint8Array, etc).
Test and fix JSZip.external.
Now, users can override the `JSZip.external.Promise` object and use
their own.
Nodejs stream and loadAsync: add an error.
A zip file is designed to be read backward so a stream is not suited
for this task. We could read the whole stream in memory but that would
be very counter-intuitive. The previous message is too generic ("The
data of [...] is in an unsupported format") and a better message will
save hours of debugging.
JSHint: add enforcing rules.
JSHint wasn't configured correctly. This commit adds enforcing rules
and apply them on production files, test files and documentation files.
Also fix offending lines.
Upgrade dependencies.
- es6-promise is kept in 3.0 until
  stefanpenner/es6-promise#177 is released
- grunt-contrib-connect is kept in 1.0.0 until
  gruntjs/grunt-contrib-connect#213 is resolved
Add array support in async().
It almost worked, we just needed a concat fix.

@dduponchel dduponchel merged commit cb28f5e into Stuk:jszip_v3 Apr 11, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dduponchel dduponchel deleted the dduponchel:blob branch Apr 11, 2016

@dduponchel dduponchel referenced this pull request Apr 12, 2016

Merged

Release 3.0.0 #278

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment