Improve browserify/webpack support #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit, we now allow developers to remove the `stream` shim
from browserify/webpack bundles to reduce the final size. Moreover, we re-use
the existing `stream` shim to deduplicate code.
Now, you can use `--dg false --bare` with browserify and
```js
module.exports = {
node: {
"stream": "empty",
global: false,
process: false,
Buffer: false
}
};
```
as webpack configuration, JSZip won't throw an error.
JSZip doesn't need it but `lie` (the `Promise` shim) does. This
dependency is only called when the js runtime doesn't provide a `Promise`.
The minimalist browserify flags (to work in all browsers) are `--no-builtins
--insert-global-vars global` and the minimalist webpack configuration is now
```js
module.exports = {
node: {
"stream": "empty",
global: true,
process: false,
Buffer: false
}
};
```
If the `global` object is not available in the bundle, you will get an
error in old browsers.
Merged
|
Any configs or hints how it works for Rollup? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request allows developers to remove the
streamshimfrom browserify/webpack bundles to reduce the final size. Moreover, we re-use
the existing
streamshim to deduplicate code.Edit: this is only true for recent browsers, see below.
Now, you can use
--dg false --barewith browserify andas webpack configuration, JSZip won't throw an error.
Includes #329.
Edit:
JSZip depends on
liewhich needs theglobalvariable. This is triggered inold browsers and all versions of IE.
The minimalist browserify flags (to work in all browsers) are
--no-builtins --insert-global-vars globaland the minimalist webpack configuration is now