New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a copy with blob output. #357

Merged
merged 1 commit into from Sep 28, 2016

Conversation

Projects
None yet
1 participant
@dduponchel
Collaborator

dduponchel commented Sep 25, 2016

The actual memory consumption will actually depends on the
implementation but this fix could avoid a copy of the result.
To build the final Blob, instead of List[Uint8Array] -> ArrayBuffer -> Blob,
we can directly do List[ArrayBuffer] -> Blob.

Remove a copy with blob output.
The actual memory consumption will actually depends on the
implementation but this fix could avoid a copy of the result.
To build the final Blob, instead of List[Uint8Array] -> ArrayBuffer -> Blob,
we can directly do List[ArrayBuffer] -> Blob.

@dduponchel dduponchel merged commit 73df7e1 into Stuk:master Sep 28, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dduponchel dduponchel deleted the dduponchel:blob_output branch Sep 28, 2016

@dduponchel dduponchel referenced this pull request Oct 5, 2016

Merged

Release v3.1.3 #365

@dduponchel dduponchel referenced this pull request Aug 19, 2017

Merged

Fix ie11 memory leak #429

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment